GS/Vulkan: Use dynamic rendering instead of render passes #11179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Since
VK_KHR_dynamic_rendering_local_readis a thing now, we can use dynamic rendering and still have our feedback loops.I'm mainly PRing this since it's a different approach that may help with the RDNA3 crashes. I don't have a RDNA3 GPU, so I have no idea if it does or not.
If it does help with RDNA3, then I'll re-add a render pass fallback path for Kepler and Polaris, since it doesn't support the local read extension, and we'd lose Vulkan support for those GPUs otherwise. But if it doesn't, it's potentially not worth bothering with this change in the first place.
Rationale behind Changes
~10% lower CPU usage on GS thread in barrier-heavy situations.
Suggested Testing Steps
Check RDNA3.