Debugger: initialise SavedAddress.address with 0 instead of NULL #10578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Uses an int 0 instead of NULL as the initialiser for the default address
Rationale behind Changes
In c++11 and higher it's valid for NULL to be
nullptr_t
instead of just a0
or((void *)0)
(see https://en.cppreference.com/w/cpp/types/NULL , though the only platform that i know of that actually does this by default via their stddef.h is musl libc). When that's the case:since the intent is a default for
u32
, a 0 works all the time.Suggested Testing Steps
None needed.