Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added recipe steps for user and email settings #6203

Closed
wants to merge 2 commits into from
Closed

Added recipe steps for user and email settings #6203

wants to merge 2 commits into from

Conversation

jersiovic
Copy link
Contributor

I needed to set for my tests some of these settings, so in order to automate the job I needed those steps, hope it is ok for tu to merge it

agriffard
agriffard reviewed May 17, 2020
View reviewed changes
...dCore.Themes/TheTheme/Views/OrchardCore.Users/ResetPassword/ResetPasswordConfirmation.cshtml Outdated

<h1>@T["Reset Password"]</h1>
<p>
@T["Your password has been reset. Melon"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melon?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upps sorry this is a test I made cause I was not able to override this cshtml I forgot to undo those changes

agriffard
agriffard reviewed May 17, 2020
View reviewed changes
src/OrchardCore.Themes/TheTheme/Views/OrchardCore.Users/ResetPassword/ResetPassword.cshtml Outdated
</div>
</div>
<div class="form-group">
<label asp-for="PasswordConfirmation" class="col-md-3 control-label">@T["New password confirmation Melon"]</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melon?

agriffard
agriffard reviewed May 17, 2020
View reviewed changes
...Core.Themes/TheTheme/Views/OrchardCore.Users/ResetPassword/ForgotPasswordConfirmation.cshtml Outdated
ViewLayout = "Layout__Login";
}

<h1>@T["Forgot Password confirmation Melon"]</h1>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melon?

agriffard
agriffard reviewed May 17, 2020
View reviewed changes
src/OrchardCore.Themes/TheTheme/Views/OrchardCore.Users/ResetPassword/ForgotPassword.cshtml Outdated
<form asp-controller="ResetPassword" asp-action="ForgotPassword" method="post" class="form-horizontal">
<div asp-validation-summary="All" class="text-danger"></div>
<div class="form-group">
<label asp-for="UserIdentifier" class="col-md-4 control-label">@T["Email or user name Melon"]</label>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Melon?

@agriffard
Copy link
Member

See also this PR #5556 and this issue #5558

@agriffard
Copy link
Member

Build error:
Recipes\SmtpSettingsStep.cs(6,19): error CS0234: The type or namespace name 'Recipes' does not exist in the namespace 'OrchardCore' (are you missing an assembly reference?)

@jersiovic jersiovic force-pushed the recipeStepsUserAndEmailSettings branch from 391c154 to 8a77990 Compare May 17, 2020 11:23
@agriffard
Copy link
Member

The SMTP step needs is a bit sensitive because it can contain password information:
#5556 (comment)

@jersiovic
Copy link
Contributor Author

the build error was fixed on next force-push of the branch.
Ok I will think about those points you commented. Thank you

@JoshLefebvre
Copy link
Contributor

Any further progress on this PR? This is an important one for me as I would really like to automate the process of setting up Smtp settings for new tenants

@deanmarcussen
Copy link
Member

Take a look at this concept and see if it meets your needs #6421

@JoshLefebvre
Copy link
Contributor

@deanmarcussen Wow great timing! Yep the encrypted option would work out perfectly for my scenario. Thanks!

@jersiovic
Copy link
Contributor Author

I close this PR, cause what deanmarcussen is better

@jersiovic jersiovic closed this Jun 16, 2020
@agriffard agriffard deleted the recipeStepsUserAndEmailSettings branch October 5, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agriffard agriffard agriffard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jersiovic @agriffard @JoshLefebvre @deanmarcussen