Missing deployment steps

[agriffard]

Some settings do not have a deployment step to import (IRecipeStepHandler) and export (IDeploymentSource) them:

• Smtp (See Smtp Deployment step #5556, Recipe Secrets Section  #6421)
• Admin : Confirmed no secrets.
• Login : Confirmed no secrets.
• Registration : Confirmed no secrets.
• ResetPassword : Confirmed no secrets.
• ChangeEmail : Confirmed no secrets.
• BackgroundTask : No admin menu, and does not use Site Settings.
• GraphQL : Not relevant. These are provided by IOptions<GraphQLSettings> (just should have been named GraphQLOptions, not settings)
• ReCaptcha : Has secret. Manages secret incorrectly, with no data protection, so is in plain text.
• FacebookSettings: Has secret. Has its own recipe step. Should not be managed by generic site settings.
• FacebookLogin: Has no secret. Has its own recipe step. Should not be managed by generic site settings.
• GitHubAuthentication: Has secret. Should not be managed by generic site settings.
• GoogleAnalytics: Has no secret. Has its own recipe step. Should not be managed by generic site settings.
• GoogleAuthentication: Has secret. Has its own recipe step. Should not be managed by generic site settings.
• Https: Confirmed no secrets.
• Microsoft Azure AD: Has no secrets. Has its own recipe step. Should not be managed by generic site settings.
• Microsoft Account Authentication: Has secrets. Has its own recipe step. Should not be managed by generic site settings.
• OpenIdClientSettings: Has secrets. Has its own recipe step. Should not be managed by generic site settings.
• OpenIdServerSettings: Has no secrets. Has its own recipe step. Should not be managed by generic site settings.
• OpenIdValidationSettings: Has no secrets. Has its own recipe step. Should not be managed by generic site settings.
• ReverseProxy: Confirmed no secrets.
• Taxonomy Filter Settings: Confirmed no secrets.
• Shortcodes templates.
• Sitemaps.
• Twitter: Has secrets. Has its own recipe step. Should not be managed by generic site settings.
• TwitterSignin: Has secrets. Should not be managed by generic site settings.

[deanmarcussen]

@agriffard if you have time, can you evaluate these, and mark the ones with Secrets that cannot be handled as a simple sitesettings export (would help to know how many we are dealing with here)

[deanmarcussen]

Also sitemaps does not have a deployment / recipe step yet (not totally site settings related)

[hishamco]

@agriffard could you please mark the once are done, may I assist it you on this

[deanmarcussen]

Adding to this list Recipes Steps which exist, but have no mechanism for handling secrets, so throw exceptions when used.

• GoogleAuthenticationSettingsStep
• FacebookSettingsStep

Related also #6364 and we will need to review other steps for the same issue.

Search for anything using a DataProtectionProvider

[agriffard]

Ok, to be clear:
Most have an import step (that inherits from IRecipeStepHandler) but lacks an export class (that inherits from IDeploymentSource)

[agriffard]

could you please mark the once are done, may I assist it you on this

@hishamco When I do a PR, I add the #link next to the task and when it is merged, I will check the task are done.

During the previous triage meeting, we were still discussing if we wanted a generic way to export settings (@Piedone 's proposal, that has been closed) or if we have to develop an export step for each settings or a generic Settings deployment step with opt-ins (#5325).

We also discussed about the way to handle the ones that have secrets (@deanmarcussen 's PR about Smtp settings #6421)

[deanmarcussen]

Further notes about a design for a generic settings handler (if we choose to go that way)
#5325

I think it's quite positive to have a generic handler, but we agreed this could not handle secrets, so worth evaluating how many "settings" would work with a generic handler, to evaluate if someone wants to write it :)

[vitalybrandes]

Can i export and import existing users using deployment?

[deanmarcussen]

Can i export and import existing users using deployment?

You cannot currently do this.

I am working towards being able to handle secrets during deployment on tis pr #6421

When that is completed - it's not ready, we might be able to consider import and export of users through deployment.

[Piedone]

While you can't export and import users per se but you can create users from a recipe with the ˙createUser command (see).

[deanmarcussen]

Rereading this. Making a note here of the steps which are not secret related, shouldn't use generic site settings, and can be added now @hishamco if you want to?

Some settings do not have a deployment step to import (IRecipeStepHandler) and export (IDeploymentSource) them:

• FacebookLogin: Has no secret. Has its own recipe step. Should not be managed by generic site settings.
• GoogleAnalytics: Has no secret. Has its own recipe step. Should not be managed by generic site settings.
• Microsoft Azure AD: Has no secrets. Has its own recipe step. Should not be managed by generic site settings.
• OpenIdServerSettings: Has no secrets. Has its own recipe step. Should not be managed by generic site settings. - Already there.
• OpenIdValidationSettings: Has no secrets. Has its own recipe step. Should not be managed by generic site settings.
• Sitemaps.

[agriffard]

I will make a PR for the missing steps @deanmarcussen @hishamco .

[sebastienros]

Are we still missing some? Should we create individual issue instead?

[deanmarcussen]

Are we still missing some? Should we create individual issue instead?

Only the ones with data protected secrets (I think), so they'll all get covered if I ever finish the secrets module off