Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

:focus-visible css compatibility when loading polyfill #324

Closed
Lausselloic opened this issue Feb 14, 2020 · 0 comments · Fixed by #326
Closed

:focus-visible css compatibility when loading polyfill #324

Lausselloic opened this issue Feb 14, 2020 · 0 comments · Fixed by #326
Assignees
@ffoodd
Labels
feature js Pull requests that update Javascript code v4
Milestone
4.5.0

Comments

@Lausselloic
Copy link
Member

Lausselloic commented Feb 14, 2020 •
edited by ffoodd
Loading

When using focus-visible on an angular app css defined in boosted.css doesn't apply
According to WICG/focus-visible#179 maybe it could be more Javascript agnostic to replace

.js-focus-visible :focus:not(.focus-visible) {
  outline: none;
}

with

.js-focus-visible :focus:not([data-focus-visible-added]) {
  outline: none;
}

In boosted.css. That will be transparent for boosted itself but ease the integration in Angular or Vue projects
@ffoodd ffoodd changed the title :focus-within css compatibility when loading polyfill :focus-visible css compatibility when loading polyfill Feb 17, 2020
@ffoodd ffoodd self-assigned this Feb 17, 2020
@ffoodd ffoodd added js Pull requests that update Javascript code v5 labels Feb 17, 2020
@ffoodd ffoodd added this to the 5.0.0-alpha milestone Feb 17, 2020
@ffoodd ffoodd added v4 and removed v5 labels Feb 18, 2020
@ffoodd ffoodd modified the milestones: 5.0.0-alpha, 4.4.2 Feb 18, 2020
@ffoodd ffoodd linked a pull request Feb 18, 2020 that will close this issue
After 4.4.1 #326
Merged
ffoodd added a commit that referenced this issue Feb 18, 2020
@ffoodd
feat(focus-visible): chack data-attribute instead of class to close #324
5255f21
@ffoodd ffoodd mentioned this issue May 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffoodd ffoodd

Labels
feature js Pull requests that update Javascript code v4
Projects
None yet
Milestone
4.5.0
Development

Successfully merging a pull request may close this issue.

After 4.4.1 Orange-OpenSource/Orange-Boosted-Bootstrap
2 participants
@ffoodd @Lausselloic