feat(focus-visible): chack data-attribute instead of class to close #324

Orange-OpenSource · Feb 18, 2020 · 5255f21 · 5255f21
1 parent 32868be
commit 5255f21
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/scss/_custom-forms.scss b/scss/_custom-forms.scss
@@ -51,7 +51,7 @@
   }
 
   // Boosted mod
-  .js-focus-visible &:focus:not(.focus-visible) ~ .custom-control-label::before {
+  .js-focus-visible &:focus:not([data-focus-visible-added]) ~ .custom-control-label::before {
     outline: 0;
   }
   // end mod
@@ -157,7 +157,7 @@
     outline-color: $black;
   }
 
-  .js-focus-visible .custom-control-input:checked:focus:not(.focus-visible) ~ .custom-control-label::before {
+  .js-focus-visible .custom-control-input:checked:focus:not([data-focus-visible-added]) ~ .custom-control-label::before {
     outline: 0;
   }
   //end mod
@@ -242,7 +242,7 @@
       }
     }
 
-    .js-focus-visible &:focus:not(.focus-visible) ~ .custom-control-label::after {
+    .js-focus-visible &:focus:not([data-focus-visible-added]) ~ .custom-control-label::after {
       outline: 0;
     }
   }

diff --git a/scss/_o-switches.scss b/scss/_o-switches.scss
@@ -70,7 +70,7 @@
       outline-color: theme-color("primary");
     }
 
-    .js-focus-visible &:focus:not(.focus-visible) + .toggle {
+    .js-focus-visible &:focus:not([data-focus-visible-added]) + .toggle {
       outline: 0;
     }
 

diff --git a/scss/_reboot.scss b/scss/_reboot.scss
@@ -75,8 +75,8 @@ body {
 // Boosted mod
 // Using the :focus-visible polyfill to hide outline defensively
 // See https://github.com/WICG/focus-visible
-.js-focus-visible :focus:not(.focus-visible),
-.js-focus-visible .focus:not(.focus-visible) {
+.js-focus-visible :focus:not([data-focus-visible-added]),
+.js-focus-visible .focus:not([data-focus-visible-added]) {
   outline: 0 !important;
 }
 // end mod