Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shared-data): remove command schema 11 changes #17546

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Feb 18, 2025

Changes relative to the release are not allowed in command schema 11, since it will ship in 8.3.0. Changes should only be made to command schema 12.

These changes come from:

These are all covered in schema 12 by subsequent schema generation exports.

Changes relative to the release are not allowed in command schema 11,
since it will ship in 8.3.0. Changes should only be made to command
schema 12.
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.17%. Comparing base (2f3849d) to head (db02ad1).
Report is 11 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17546   +/-   ##
=======================================
  Coverage   26.17%   26.17%           
=======================================
  Files        2838     2838           
  Lines      217730   217730           
  Branches     9280     9280           
=======================================
  Hits        56989    56989           
  Misses     160724   160724           
  Partials       17       17           
Flag Coverage Δ
app 3.42% <ø> (-0.01%) ⬇️
protocol-designer 18.85% <ø> (ø)
step-generation 4.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sfoster1 sfoster1 requested a review from jbleon95 February 20, 2025 17:42
Copy link
Contributor

@ddcc4 ddcc4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks fine. Could you add a comment to the description mentioning the PR where the original change was made?

(Better yet, if you can generate the PR with git revert, I think it'll automatically link to the original commit, which makes tracing through code history easier.)

@sfoster1
Copy link
Member Author

@ddcc4 I noted the PRs and commits that added the stuff that's now removed; unfortunately I can't do this by revert because we squash merge and so the commits would include other stuff that we wouldn't want to revert.

@sfoster1 sfoster1 merged commit 98f9277 into edge Feb 20, 2025
70 checks passed
@sfoster1 sfoster1 deleted the undo-bad-command-schema-changes branch February 20, 2025 19:14
@ddcc4
Copy link
Contributor

ddcc4 commented Feb 20, 2025

unfortunately I can't do this by revert because we squash merge and so the commits would include other stuff that we wouldn't want to revert.

Gotcha. Yeah, this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants