feat(api): add aspirate and dispense while tracking commands #17286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f67373 to
cc3b520
Compare
sfoster1
requested changes
Jan 16, 2025
|
535eb22 to
e877d9d
Compare
e877d9d to
dba1630
Compare
sfoster1
approved these changes
Jan 22, 2025
caila-marashaj
added a commit
that referenced
this pull request
Feb 11, 2025
sfoster1
added a commit
that referenced
this pull request
Feb 20, 2025
Changes relative to the release are not allowed in command schema 11, since it will ship in 8.3.0. Changes should only be made to command schema 12. These changes come from: - #17286 ( 48a028a ) which added aspirate and dispense while tracking commands - #17300 ( 35686bc ) and #17206 ( cec46ef) which added initial stacker EVT commands - #17259 ( 7393c92) which added a move lid command These are all covered in schema 12 by subsequent schema generation exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pr creates new protocol engine commands for
AspirateWhileTrackingandDispenseWhileTracking. These don't affect the functionality of the existingAspirateandDispensepe commands. I'm going to add the actualpipetting.pyimplementation of these in a follow-up pr, and it's going to involve some refactors, so for now it's wired up and just not implemented below the protocol engine.Changelog
AspirateWhileTracking,DispenseWhileTrackingpe commandscommand_unions