change: clean leading quote from notification message #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w568w
requested changes
Nov 29, 2024
ppolariss
reviewed
Nov 29, 2024
|
Why? Wouldn’t ‘#{1,2}’ match 2 # when possible?
On Nov 29, 2024, at 23:40, w568w ***@***.***> wrote:
@w568w commented on this pull request.
________________________________
In models/notification.go<#168 (comment)>:
@@ -126,16 +126,23 @@ func (message *Notification) checkConfig() {
message.Recipients = newRecipient
}
+var (
+ reHole = regexp.MustCompile(`#{1,2}\d+`)
A counterexample:
##12345 foo bar
will be transformed into:
# foo bar
It this expected?
—
Reply to this email directly, view it on GitHub<#168 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC463HNURJBQP6ELOF64SIL2DCDGPAVCNFSM6AAAAABSXKCX4GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZQGE4TIMZVGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I misread it. You can see that I have removed that comment. |
w568w
requested changes
Nov 29, 2024
JingYiJun
reviewed
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.