Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: clean leading quote from notification message #167

Closed
wants to merge 2 commits into from

Conversation

singularity-s0
Copy link
Contributor

This PR modifies the content of notifications description to remove the quote at the beginning. It makes notification previews easier to read.

Please review carefully since I'm not familiar with the language.

@ppolariss
Copy link
Member

Great idea, but there are a few issues to address:

  1. Remove the ^ in the floor regex. Otherwise, when processing strings like ##456\n##123\nfoo, it will retain ##123\nfoo.
  2. Add regex support for matching holes (#num).
  3. Have you considered removing newline characters(\n) using regex?
  4. I'm not sure what will happen if the description is empty after removal. Some push mechanisms might encounter issues. I suggest returning the original content if the match results in an empty string.
  5. It would be better to apply this function once at the following location in the code: [notification.go (L156-L159)].

@singularity-s0
Copy link
Contributor Author

Closing this PR in favor of #168

@singularity-s0 singularity-s0 deleted the patch-1 branch November 29, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants