Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yml validation schema generation and schema checker #67

Merged
merged 15 commits into from
May 27, 2024

Conversation

ClemensLinnhoff
Copy link
Contributor

@ClemensLinnhoff ClemensLinnhoff commented Mar 13, 2024

Reference to a related issue in the repository

#64

Add a description

  • Automatically generate yml schema files by rules2yml.py. The schema files are generated in <rules_folder>/schema.
  • Validate each rule file with the respective schema before loading it.

Mention a member

@masipp, @jdsika

Check the checklist

  • My code and comments follow the contributors guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation for osi-validation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests / travis ci pass locally with my changes.

…in osi_rules

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff linked an issue Mar 13, 2024 that may be closed by this pull request
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika March 13, 2024 14:39
@ClemensLinnhoff ClemensLinnhoff marked this pull request as ready for review March 13, 2024 14:40
@ClemensLinnhoff ClemensLinnhoff requested a review from masipp April 4, 2024 05:16
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@jdsika
Copy link
Contributor

jdsika commented May 16, 2024

@ClemensLinnhoff we have some conflicts now

Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff
Copy link
Contributor Author

@ClemensLinnhoff we have some conflicts now

I fixed the conflicts. Ready for review.

@jdsika jdsika added feature request Proposals which enhance the interface or add additional features. quality Quality improvements. labels May 27, 2024
doc/usage.adoc Show resolved Hide resolved
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@partner.bmw.de>
@ClemensLinnhoff ClemensLinnhoff requested a review from jdsika May 27, 2024 12:29
@jdsika jdsika merged commit 03af25e into master May 27, 2024
6 checks passed
@jdsika jdsika deleted the 64-validating-a-yml-rule branch May 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Proposals which enhance the interface or add additional features. quality Quality improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validating a .yml rule
2 participants