This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 285
Number Precision - Use Repo.CurrencyValue to represent amounts uniformly #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it would be useful to define some requirements for code review and the merge conditions; I'll check off what we have confirmed:
|
@placer14 @cpacia - This is indicative of the changed responses due to the repo.CurrencyValue introduction. |
* origin/master: Fix 'exported method OpenBazaarNode.GetOrder should have comment or be unexported' Update error message in test case Address review notes Fix linting warnings Extracted method core.GetOrder(), added unit test for it Conflicts: api/jsonapi.go core/order.go
For others following along, we're going to stick a pin on this PR and merge it into a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the changes required for bringing in repo.CurrencyValue to represent amount/value uniformly across the code.
All the wallet interface methods have also been updated to use CurrencyValue. All the wallet implementations also have been updated.