You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
We probably want inputs and outputs showing the full definition, though it's probably okay to allow inputs where a currency string is offered to continue allowing it OR provide another key with the full definition so a different divisibility could be used if desired. If the full definition is provided in key currency then the string could provided instead inside currencyCode in a parallel key which defaults to the node's definition of that code.
Items which need to be resolved as part of the ETH milestone:
GET /wallet/balance should indicate TETH properly (currently shows as ETH)
GET /ob/listing, GET /ob/listings, and POST /ob/listing all have representations of the currency symbol where we probably want to show the full definition.
POST /ob/orderspend: The amount has another nested amount and we probably don't want to be redundant. Maybe that outer amount should be payment? We might consider the same change in the response body as well. Ex:
In response to requests/responses posted in #1666 (https://gist.github.com/amangale/2d91c8dc4eb95a1fdf34363b83cf901d).
General thoughts:
currency
then the string could provided instead insidecurrencyCode
in a parallel key which defaults to the node's definition of that code.Items which need to be resolved as part of the ETH milestone:
GET /wallet/balance
should indicate TETH properly (currently shows as ETH)GET /ob/listing
,GET /ob/listings
, andPOST /ob/listing
all have representations of the currency symbol where we probably want to show the full definition.POST /ob/orderspend
: Theamount
has another nestedamount
and we probably don't want to be redundant. Maybe that outeramount
should bepayment
? We might consider the same change in the response body as well. Ex:POST /ob/purchase
input JSON forpaymentCoin
should be full definitionGET /ob/order/:orderId
should return full definitions foracceptedCurrencies
Bonus:
The text was updated successfully, but these errors were encountered: