Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

Prevent POSTBulkUpdateCurrency API from updating CRYPTO-type listings #1633

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

cpacia
Copy link
Member

@cpacia cpacia commented Jun 12, 2019

The API would fail if the user had a cryptocurrency listing set since we only
allow one accepted currency for cryptolistings.

This commit changes it to not apply the bulk update to cryptolistings and adds a test.

Closes #1632

@coveralls
Copy link

coveralls commented Jun 12, 2019

Coverage Status

Coverage increased (+2.6%) to 38.229% when pulling 6a859ad on bulkupdate into ef06d07 on master.

Copy link
Member

@placer14 placer14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test! 💪 GTM

core/listings_test.go Outdated Show resolved Hide resolved
The API would fail if the user had a cryptocurrency listing set since we only
allow one accepted currency for cryptolistings.

This commit changes it to not apply the bulk update to cryptolistings and adds a test.

Closes #1632
@placer14 placer14 changed the base branch from master to v0.13.4-rc June 24, 2019 16:49
@placer14 placer14 changed the base branch from v0.13.4-rc to master June 24, 2019 16:50
@cpacia cpacia merged commit 5ea9eef into master Jul 22, 2019
@placer14 placer14 deleted the bulkupdate branch July 23, 2019 16:01
@placer14 placer14 changed the title Fix bug in POSTBulkUpdateCurrency API Prevent POSTBulkUpdateCurrency API from updating CRYPTO-type listings Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bulkupdatecurrency fails if the user has crypto listings
3 participants