Fix bug in POSTBulkUpdateCurrency API

The API would fail if the user had a cryptocurrency listing set since we only
allow one accepted currency for cryptolistings.

This commit changes it to not apply the bulk update to cryptolistings and adds a test.

Closes #1632

core/listings.go

@@ -1409,6 +1409,13 @@ func (n *OpenBazaarNode) SetCurrencyOnListings(currencies []string) error {
 				return err
 			}
 
+			// Cryptocurrency listings can only have one currency listed and since it's
+			// a trade for one specific currency for another specific currency it isn't
+			// appropriate to apply the bulk update to this type of listing.
+			if sl.Listing.Metadata.ContractType == pb.Listing_Metadata_CRYPTOCURRENCY {
+				return nil
+			}
+
 			SetAcceptedCurrencies(sl, currencies)
 
 			savedCoupons, err := n.Datastore.Coupons().Get(sl.Listing.Slug)

core/listings_test.go

@@ -0,0 +1,60 @@
+package core_test
+
+import (
+	"github.com/OpenBazaar/openbazaar-go/test"
+	"github.com/OpenBazaar/openbazaar-go/test/factory"
+	"testing"
+)
+
+func TestOpenBazaarNode_SetCurrencyOnListings(t *testing.T) {
+	node, err := test.NewNode()
+	if err != nil {
+		t.Fatal(err)
+	}
+
+	var (
+		regularListingSlug    = "test_regular_listing"
+		cryptoListingSlug     = "test_crypto_listing"
+		newAcceptedCurrencies = []string{"BCH", "LTC"}
+		cryptoListingCurrency = "TBTC"
+	)
+
+	regularListing := factory.NewListing(regularListingSlug)
+	regularListing.Metadata.AcceptedCurrencies = []string{"TBTC"}
+
+	if err := node.CreateListing(regularListing); err != nil {
+		t.Fatal(err)
+	}
+
+	cryptoListing := factory.NewCryptoListing(cryptoListingSlug)
+	regularListing.Metadata.AcceptedCurrencies = []string{cryptoListingCurrency}
+
+	if err := node.CreateListing(cryptoListing); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := node.SetCurrencyOnListings(newAcceptedCurrencies); err != nil {
+		t.Fatal(err)
+	}
+
+	checkListing, err := node.GetListingFromSlug(regularListingSlug)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if checkListing.Listing.Metadata.AcceptedCurrencies[0] != newAcceptedCurrencies[0] ||
+		checkListing.Listing.Metadata.AcceptedCurrencies[1] != newAcceptedCurrencies[1] ||
+		len(checkListing.Listing.Metadata.AcceptedCurrencies) != len(newAcceptedCurrencies) {
+
+		t.Errorf("Listing %s expected accepted currency list %v, got %v", newAcceptedCurrencies, regularListingSlug, checkListing.Listing.Metadata.AcceptedCurrencies)
+	}
+
+	checkListing2, err := node.GetListingFromSlug(cryptoListingSlug)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(checkListing2.Listing.Metadata.AcceptedCurrencies) != 1 || checkListing2.Listing.Metadata.AcceptedCurrencies[0] != cryptoListingCurrency {
+
+		t.Errorf("Listing %s expected accepted currency list %v, got %v", cryptoListingSlug, []string{cryptoListingCurrency}, checkListing2.Listing.Metadata.AcceptedCurrencies)
+	}
+
+}