Elm client generator refactoring #4891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* All of types are now nested; * Adding a discriminator creates a custom type wrapping all variants and a 'catch-all' fallback variant.
9a84fd5 to
2618452
Compare
|
@eriktim I've sync'd changes from master to 5.0.x and resolved some merge conflicts related to the Elm client generator. Please review the latest code in the 5.0.x branch to see if the merge looks good to you. |
|
@wing328 thanks for the heads up. I see you restored |
|
I'll remove that too in the latest 5.0.x branch as it's causing tests to fail.\ UPDATE: Done |
|
Awesome work |
|
Wonderful :D |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactoring of the Elm generator. See this new guide for more background.
Closes #310, #1589, #3578 and #4583.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@wing328 Can you have a look? And would it be possible to merge this without squashing?