Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elm] Add support for petstore spec #15257

Merged
merged 10 commits into from
May 2, 2023

Conversation

Qluxzz
Copy link
Contributor

@Qluxzz Qluxzz commented Apr 18, 2023

Add support for generating the petstore client.

  • Change default request body from Json to any variant of Http.Body, to allow form param body
  • Added support for form params, including files
  • Fix mapping multiple response types while we only can handle one today
  • Fix order of operation with parenthesis
  • Fix not exporting needed enum to string methods from Api.Data
  • Fix handling of inline enums and enum refs
  • Remove whitespace lambda now allows better formatting of templates

I also removed the old generated petstore client in samples/openapi3/petstore/elm, this should probably have been removed in #4891, since there has been no config to generate it since then. That generated client was also generated before the big refactor in that same pull request.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @eriktim

@Qluxzz Qluxzz force-pushed the add-support-for-petstore branch 2 times, most recently from 13950c5 to 0001a42 Compare April 20, 2023 13:11
@Qluxzz Qluxzz force-pushed the add-support-for-petstore branch from 0001a42 to dc8729e Compare April 20, 2023 15:37
@wing328
Copy link
Member

wing328 commented Apr 26, 2023

@Qluxzz thanks for the PR.

Would it be possible to setup Github workflow to test the Elm Petstore client as part of this PR? 🙏

ref:

@wing328 wing328 added this to the 6.6.0 milestone Apr 26, 2023
@Qluxzz Qluxzz requested a review from jimschubert as a code owner April 26, 2023 13:07
@Qluxzz
Copy link
Contributor Author

Qluxzz commented Apr 26, 2023

Definitely, I have added a pipeline that validates that all elm files successfully compiles.

@Qluxzz
Copy link
Contributor Author

Qluxzz commented May 2, 2023

@wing328 the CI failures seem to be related to python-aiohttp and python-nextgen which is nothing I have touched in this PR.

@wing328 wing328 merged commit 42fa07d into OpenAPITools:master May 2, 2023
@wing328
Copy link
Member

wing328 commented May 2, 2023

Agreed.

I've just merged it. Thanks for the PR 👍

@Qluxzz Qluxzz deleted the add-support-for-petstore branch November 20, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants