-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 2404 allow faster cancel from PI #2405
Merged
msevestre
merged 3 commits into
develop
from
2404-allow-faster-cancel-from-parameter-identifications
Jan 23, 2025
Merged
Fixes 2404 allow faster cancel from PI #2405
msevestre
merged 3 commits into
develop
from
2404-allow-faster-cancel-from-parameter-identifications
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msevestre
reviewed
Jan 23, 2025
src/OSPSuite.Core/Domain/Services/ParameterIdentifications/ParameterIdentificationEngine.cs
Outdated
Show resolved
Hide resolved
msevestre
requested changes
Jan 23, 2025
src/OSPSuite.Core/Domain/Services/ParameterIdentifications/ParameterIdentificationEngine.cs
Show resolved
Hide resolved
tests/OSPSuite.Core.Tests/Domain/ParameterIdentificationRunSpecs.cs
Outdated
Show resolved
Hide resolved
tests/OSPSuite.Core.Tests/Domain/ParameterIdentificationRunSpecs.cs
Outdated
Show resolved
Hide resolved
src/OSPSuite.Core/Domain/Services/ParameterIdentifications/ParameterIdentificationEngine.cs
Outdated
Show resolved
Hide resolved
msevestre
requested changes
Jan 23, 2025
src/OSPSuite.Core/Domain/Services/ParameterIdentifications/ParameterIdentificationEngine.cs
Show resolved
Hide resolved
I guess I still had some fancy code in my local simmodel that made this possible. This PR alone isn't enough because the stock simmodel in v12 does not stop PI simulation runs due to the ShowProgress flag being false |
rwmcintosh
added a commit
that referenced
this pull request
Feb 3, 2025
* Fixes #2382 Improve 'Cannot find quantity with path' message (#2383) * Fixes #2382 Improve 'Cannot find quantity with path' message * pr comments * pr comments * update simmodel (#2385) * update simmodel * update simmodel * Fixes #1743 Cannot add data to simulation? (#2387) * Fixes Comparison of passive transports: difference in "Create process rate" flag is not shown (#2395) * Fixes #2396 Cannot start a sensitivity analysis (#2397) * Fixes 2404 allow faster cancel from PI (#2405) * Fixes 2404 allow faster cancel from PI * PR feedback * pr feedback * #2257 Parameter identification change name and transfer * #2257 merge and solve comments * #2257 Review changes on constructor --------- Co-authored-by: Robert McIntosh <261477+rwmcintosh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2404
Description
We were canceling all future runs, but not stopping the current run. The runs can take quite a lot of time.
Conversely, canceling a simulation is very fast...
Type of change
Please mark relevant options with an
x
in the brackets.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Reviewer checklist
Mark everything that needs to be checked before merging the PR.
This change requires a documentation update
above is selectedScreenshots (if appropriate):
Questions (if appropriate):