Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2386 Cannot add data to simulation? #2387

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

rwmcintosh
Copy link
Member

Fixes #2386

Description

Copy/Move flags should be additive, not replaced

Type of change

Please mark relevant options with an x in the brackets.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation changes (link at least one user or developer documentation issue):
  • Algorithm update - updates algorithm documentation/questions/answers etc.
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Integration tests
  • Unit tests
  • Manual tests
  • No tests required

Reviewer checklist

Mark everything that needs to be checked before merging the PR.

  • Check if the code is well documented
  • Check if the behavior is what is expected
  • Check if the code is well tested
  • Check if the code is readable and well formatted
  • Additional checks (document below if any)
  • Check if documentation update issue(s) are created if the option This change requires a documentation update above is selected

Screenshots (if appropriate):

Questions (if appropriate):

@@ -41,7 +41,7 @@ public void InitializeDragAndDrop(ICanDragDropPresenter presenter)

_supportedEffects = DragDropEffects.Move;
if (_presenter.CopyAllowed())
_supportedEffects = DragDropEffects.Copy;
_supportedEffects |= DragDropEffects.Copy;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof... I feel shame.

@rwmcintosh rwmcintosh merged commit 9ef6d63 into develop Jan 9, 2025
1 check passed
@rwmcintosh rwmcintosh deleted the 1743-cannot-add-data-to-simulation branch January 9, 2025 13:47
rwmcintosh added a commit that referenced this pull request Jan 29, 2025
* Fixes #2382 Improve 'Cannot find quantity with path' message (#2383)

* Fixes #2382 Improve 'Cannot find quantity with path' message

* pr comments

* pr comments

* update simmodel (#2385)

* update simmodel

* update simmodel

* Fixes #1743 Cannot add data to simulation? (#2387)

* #2179 observed data reload with same settings

* #2179 Cleanup

* what if we change the interface

* remove a property

* spelling

* What if we change fixes

* #2179 code review comments

* #2179 remove unused reference

---------

Co-authored-by: Robert McIntosh <261477+rwmcintosh@users.noreply.github.com>
rwmcintosh added a commit that referenced this pull request Feb 3, 2025
* Fixes #2382 Improve 'Cannot find quantity with path' message (#2383)

* Fixes #2382 Improve 'Cannot find quantity with path' message

* pr comments

* pr comments

* update simmodel (#2385)

* update simmodel

* update simmodel

* Fixes #1743 Cannot add data to simulation? (#2387)

* Fixes Comparison of passive transports: difference in "Create process rate" flag is not shown (#2395)

* Fixes #2396 Cannot start a sensitivity analysis (#2397)

* Fixes 2404 allow faster cancel from PI (#2405)

* Fixes 2404 allow faster cancel from PI

* PR feedback

* pr feedback

* #2257 Parameter identification change name and transfer

* #2257 merge and solve comments

* #2257 Review changes on constructor

---------

Co-authored-by: Robert McIntosh <261477+rwmcintosh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add data to simulation?
2 participants