Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing observed data chrash (2) #1837

Closed
georgeDaskalakis opened this issue Dec 16, 2022 · 0 comments · Fixed by #1838
Closed

Importing observed data chrash (2) #1837

georgeDaskalakis opened this issue Dec 16, 2022 · 0 comments · Fixed by #1838

Comments

@georgeDaskalakis
Copy link
Contributor

@PavelBal commented on Wed Nov 30 2022

pksim-importerCrash.zip

  • Open the excel file
  • Load the provided configuration
  • "Add all sheets"

Application:
PK-Sim® 11.1.78

Object reference not set to an instance of an object.

Stack trace:

at OSPSuite.Infrastructure.Import.Core.DataSource.<>c__DisplayClass21_1.<validateUnitsSupportedAndSameDimension>b__2(IDimension x)
   at System.Linq.Enumerable.FirstOrDefault[TSource](IEnumerable`1 source, Func`2 predicate)
   at OSPSuite.Infrastructure.Import.Core.DataSource.validateUnitsSupportedAndSameDimension(Cache`2 columnInfos)
   at OSPSuite.Infrastructure.Import.Core.DataSource.ValidateDataSourceUnits(ColumnInfoCache columnInfos)
   at OSPSuite.Presentation.Presenters.Importer.ImporterPresenter.validateDataSource(IDataSource dataSource)
   at OSPSuite.Presentation.Presenters.Importer.ImporterPresenter.loadSheets(IDataSourceFile dataSourceFile, IReadOnlyList`1 sheetNames, String filter, String selectedNamingConvention)
   at OSPSuite.Presentation.Presenters.Importer.ImporterPresenter.loadSheetsFromDataPresenter(Object sender, ImportSheetsEventArgs args)
   at System.EventHandler`1.Invoke(Object sender, TEventArgs e)
   at OSPSuite.Presentation.Presenters.Importer.ImporterDataPresenter.ImportDataForConfirmation()
   at OSPSuite.UI.Views.Importer.ImporterDataView.onButtonImportAllClicked(Object sender, EventArgs e)
   at OSPSuite.UI.Controls.BaseUserControl.<>c__DisplayClass26_0`1.<OnEvent>b__0()
   at OSPSuite.UI.Controls.BaseUserControl.<>c__DisplayClass23_0.<OnEvent>b__0()
   at OSPSuite.Utility.Extensions.ExceptionExtensions.DoWithinExceptionHandler(Object callerObject, Action actionToExecute)

@PavelBal commented on Thu Dec 01 2022

This happens for the sheet Crew2001. The error is "Arithmetic" but the error unit column is empty. It is correct that the sheet cannot be imported, but it should not crash.


@msevestre commented on Thu Dec 01 2022

Yep. This app should never crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant