Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data importer: Unit for "Fraction" is not recognized #1886

Closed
PavelBal opened this issue Feb 3, 2023 · 3 comments · Fixed by #1892
Closed

Data importer: Unit for "Fraction" is not recognized #1886

PavelBal opened this issue Feb 3, 2023 · 3 comments · Fixed by #1892
Assignees

Comments

@PavelBal
Copy link
Member

PavelBal commented Feb 3, 2023

The default unit for the dimension "Fraction" is an empty string, which is not recognized by the importer.

image
core-importer-fraction-unit.zip

@georgeDaskalakis
Copy link
Contributor

This was aparently newly introduced by fixing a previous bug a few weeks ago

#1838

@georgeDaskalakis georgeDaskalakis self-assigned this Feb 6, 2023
@georgeDaskalakis
Copy link
Contributor

georgeDaskalakis commented Feb 6, 2023

Concerning this error in relation to #1837, the behaviour I would suggest altogether is:

A totally empty unit column is allowed and in that case the unit is empty and the dimension "Dimensionless" (this is the first one that the importer finds, if the user explicitely needs to have fraction, she will have to input it manually).

With such a behaviour the file from #1837 still throws an exception, since the measurement unit does not match the error unit (error unit column empty) for the specific sheet of the file.

@PavelBal
Copy link
Member Author

PavelBal commented Feb 6, 2023

A totally empty unit column is allowed and in that case the unit is empty and the dimension "Dimensionless" (this is the first one that the importer finds, if the user explicitely needs to have fraction, she will have to input it manually).

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants