fix: 2 problems related to Toast Component. One is its usage in Modal… #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… component will cause memory leak. The other is a display issue about abnormal offset of the Modal component when toast was popped up before.
loatheb
reviewed
Apr 21, 2022
loatheb
previously approved these changes
Apr 21, 2022
|
我看到这边lint校验没过，我的开发环境具体要需要怎么配置它呢 |
|
lint 配置你可以本地根目录跑对应的 |
auto-merge was automatically disabled
April 21, 2022 07:51
Head branch was pushed to by a user without write access
|
又失败了，我这边windows环境跑eslint显示JS内存不够，即使我设置了max_space_size |
|
这次应该没问题 |
linleiqin
approved these changes
Apr 21, 2022
kwoktung
approved these changes
Apr 21, 2022
liuzjalex
added a commit
to liuzjalex/app-monorepo
that referenced
this pull request
Apr 24, 2022
…detail * commit '48ab7d0f53a868e926aacd5cb8be5431e43ead05': (39 commits) OK-7960, OK-7789: add react-native-fast-image (OneKeyHQ#590) feat: error boundary message panel (OneKeyHQ#587) style: set Select.Option default background to undefined (OneKeyHQ#588) Update readme.md fix: splash screen OK-8127 OK-8129 (OneKeyHQ#591) OK-8041: improve withEnableAuthentication defaultValue (OneKeyHQ#589) OK-7814 `ChangeLogModal` component and `Modal` maxHeight prop (OneKeyHQ#586) OK-7527: fix check fee (OneKeyHQ#542) Feat discover OK-7805 OK-8054 (OneKeyHQ#584) feat: swap beta (OneKeyHQ#581) fix: finalize tx status timeout bug. (OneKeyHQ#585) feat: EVM Dapp Sign message flow (OneKeyHQ#576) OK-8050: fix Qcode bgColor (OneKeyHQ#583) Update readme.md Update readme.md fix: 2 problems related to Toast Component. One is its usage in Modal… (OneKeyHQ#579) chore: upgrade blockchain-libs (OneKeyHQ#582) fix: rsync app js-sdk missing files (OneKeyHQ#580) fix: electron production build issue (OneKeyHQ#578) fix: import wallet password bug OK-7755 (OneKeyHQ#568) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: 2 problems related to Toast Component. One is its usage in Modal component will cause memory leak. The other is a display issue about abnormal offset of the Modal component when toast was popped up before.