Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check fee input OK-7527 OK-7569 OK-6488 #542

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Check fee input OK-7527 OK-7569 OK-6488 #542

merged 1 commit into from
Apr 22, 2022

Conversation

hzxiao
Copy link

@hzxiao hzxiao commented Apr 17, 2022

No description provided.

@github-actions
Copy link

👋 Successfully deployed the latest commit 18d3d026847efe256eaeab72621610545eb82bb6 to https://app.test.onekey.so

@github-actions
Copy link

👋 Successfully deployed the latest commit 385df3306998f5bc1271284bbb469d37e5d32e53 to https://app.test.onekey.so

@github-actions
Copy link

👋 Successfully deployed the latest commit 4f51f03e6c70c7b7c9a171f0e7df2dd54ca14677 to https://app.test.onekey.so

@hzxiao hzxiao changed the title Check fee input Check fee input OK-7627 Apr 19, 2022
@hzxiao hzxiao changed the title Check fee input OK-7627 Check fee input OK-7527 Apr 19, 2022
@github-actions
Copy link

👋 Successfully deployed the latest commit 4ab83fda33475a9e6e8d8047fad8dfbba5304ab4 to https://app.test.onekey.so

@hzxiao hzxiao changed the title Check fee input OK-7527 Check fee input OK-7527 OK-7569 Apr 19, 2022
@github-actions
Copy link

👋 Successfully deployed the latest commit 1692c1f5c6ab3a4dd7e0a0502b54fc55dfa3bf47 to https://app.test.onekey.so

@hzxiao hzxiao requested a review from sidmorizon April 19, 2022 07:23
@github-actions
Copy link

👋 Successfully deployed the latest commit 2293242b3f809c6f4931ef6a1512b79d68a133b7 to https://app.test.onekey.so

@github-actions
Copy link

👋 Successfully deployed the latest commit 10d12058dcc4eaf6e2429d4b0731deddb9e8358c to https://app.test.onekey.so

sidmorizon
sidmorizon reviewed Apr 19, 2022
View reviewed changes
packages/engine/src/validators.ts Outdated Show resolved Hide resolved
packages/engine/src/validators.ts Show resolved Hide resolved
@hzxiao hzxiao requested a review from sidmorizon April 19, 2022 08:48
@github-actions
Copy link

👋 Successfully deployed the latest commit 1b96f42b2dbd2120d07d091da31aeb0e855b13f3 to https://app.test.onekey.so

sidmorizon
sidmorizon previously approved these changes Apr 19, 2022
View reviewed changes
packages/engine/src/validators.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

👋 Successfully deployed the latest commit 2829587452cfbafaaefe63b06904104bb4f126a1 to https://app.test.onekey.so

@github-actions
Copy link

👋 Successfully deployed the latest commit d2c0a4b9553c582fe1ae087fa0d5bce031c6f10a to https://app.test.onekey.so

@hzxiao hzxiao requested a review from sidmorizon April 20, 2022 13:26
ByteZhang1024
ByteZhang1024 previously approved these changes Apr 20, 2022
View reviewed changes
@hzxiao hzxiao force-pushed the check-fee-input branch 2 times, most recently from 3c5cd1b to facd023 Compare April 21, 2022 03:01
@github-actions
Copy link

👋 Successfully deployed the latest commit 808c6631c1f5052523b35f60c07d9061c072e767 to https://app.test.onekey.so

@github-actions
Copy link

👋 Successfully deployed the latest commit 05507e4ed3e5f23be32b84e2c6e37f0e6b777a99 to https://app.test.onekey.so

sidmorizon
sidmorizon reviewed Apr 21, 2022
View reviewed changes
packages/engine/src/errors.ts Outdated Show resolved Hide resolved
packages/kit/src/views/Send/SendEditFee.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

👋 Successfully deployed the latest commit 6a24c03ddee840908a6f812268afbc836892970d to https://app.test.onekey.so

sidmorizon
sidmorizon previously approved these changes Apr 21, 2022
View reviewed changes
@sidmorizon sidmorizon enabled auto-merge (squash) April 21, 2022 07:10
loatheb
loatheb previously approved these changes Apr 21, 2022
View reviewed changes
@github-actions
Copy link

👋 Successfully deployed the latest commit f0be3b9b9492dbdc38e325bd7d6d6265b019d4ab to https://app.test.onekey.so

ByteZhang1024
ByteZhang1024 previously approved these changes Apr 21, 2022
View reviewed changes
@hzxiao hzxiao dismissed stale reviews from ByteZhang1024, loatheb, and sidmorizon via 6550d8b April 22, 2022 04:52
@github-actions
Copy link

👋 Successfully deployed the latest commit d5e71c43f9e1fb02c7c856196c331f07cf6f7d31 to https://app.test.onekey.so

@sidmorizon sidmorizon merged commit 50a5333 into onekey Apr 22, 2022
@sidmorizon sidmorizon deleted the check-fee-input branch April 22, 2022 06:17
@hzxiao hzxiao changed the title Check fee input OK-7527 OK-7569 Check fee input OK-7527 OK-7569 OK-6488 Apr 22, 2022
liuzjalex added a commit to liuzjalex/app-monorepo that referenced this pull request Apr 24, 2022
@liuzjalex
fix: Merge commit '48ab7d0f53a868e926aacd5cb8be5431e43ead05' into tx_…
510bf93 
…detail

* commit '48ab7d0f53a868e926aacd5cb8be5431e43ead05': (39 commits)
  OK-7960, OK-7789: add react-native-fast-image (OneKeyHQ#590)
  feat: error boundary message panel (OneKeyHQ#587)
  style: set Select.Option default background to undefined (OneKeyHQ#588)
  Update readme.md
  fix: splash screen OK-8127 OK-8129 (OneKeyHQ#591)
  OK-8041: improve withEnableAuthentication defaultValue (OneKeyHQ#589)
  OK-7814 `ChangeLogModal` component and `Modal` maxHeight prop (OneKeyHQ#586)
  OK-7527: fix check fee (OneKeyHQ#542)
  Feat discover OK-7805 OK-8054 (OneKeyHQ#584)
  feat: swap beta (OneKeyHQ#581)
  fix: finalize tx status timeout bug. (OneKeyHQ#585)
  feat: EVM Dapp Sign message flow (OneKeyHQ#576)
  OK-8050: fix Qcode bgColor (OneKeyHQ#583)
  Update readme.md
  Update readme.md
  fix: 2 problems related to Toast Component. One is its usage in Modal… (OneKeyHQ#579)
  chore: upgrade blockchain-libs (OneKeyHQ#582)
  fix: rsync app js-sdk missing files (OneKeyHQ#580)
  fix: electron production build issue (OneKeyHQ#578)
  fix: import wallet password bug OK-7755 (OneKeyHQ#568)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidmorizon sidmorizon sidmorizon approved these changes

@kwoktung kwoktung kwoktung approved these changes

@loatheb loatheb loatheb approved these changes

@ByteZhang1024 ByteZhang1024 ByteZhang1024 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hzxiao @sidmorizon @kwoktung @loatheb @ByteZhang1024