Added the feature of copying the headings using link icon #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronbrethorst
requested changes
Mar 12, 2024
There was a problem hiding this comment.
This is cool, thanks for adding it! I see a few things that will need to be addressed before merging.
- The link icons are invisible in light mode.
- the
<svg>elements you're generating all have the idlink. An id is supposed to be unique on the page. - clicking the link icon scrolls the page. it should only copy to the clipboard.
|
make sure you've pulled the latest bits from main and rebased on top of them. #74 will affect this PR. |
|
Okay! Got it. I am working on this. |
|
I am working on this PR again as I have some issues in my local storage. |
|
HI @aaronbrethorst, a new PR #90 has been created in place of the given PR. Please check it! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added a feature for enhancing the user experience by providing a seamless way to copy direct links to specific headings within the content using a link icon next to headings. Features implemented:
Issue fixed:
Fixed #69
Changes done:
Screenshots/Videos
✅️ By submitting this PR, I have verified the following