Remove duplicate class on related-content example #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
requested changes
Jul 11, 2024
5bdfa0d to
2b94422
Compare
alessioventuriniAND
approved these changes
Jul 15, 2024
balibirchlee
approved these changes
Jul 16, 2024
SriHV
approved these changes
Jul 16, 2024
rmccar
reviewed
Jul 18, 2024
rmccar
approved these changes
Jul 19, 2024
|
Because this has changed quite a bit and Im the only one that has reviewed it since the changes Ive requested some re-reviews |
alessioventuriniAND
approved these changes
Jul 19, 2024
SriHV
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes #3236
The related links social example had the ons-list--bare class added twice. This PR updates the logic for the related content to ensure that the right class is added. Additionally, the documentation has been updated to include variants as a parameter.
How to review this PR
Verify that the example in question no longer has the duplicate class added.
Ensure all tests pass.
Confirm that the documentation has been updated accordingly.
Checklist
This needs to be completed by the person raising the PR.