Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate class on related links social example #3236

Closed
rmccar opened this issue Jun 20, 2024 · 0 comments · Fixed by #3262
Closed

Duplicate class on related links social example #3236

rmccar opened this issue Jun 20, 2024 · 0 comments · Fixed by #3262
Assignees
Labels
Bug Something isn't working Low Priority

Comments

@rmccar
Copy link
Contributor

rmccar commented Jun 20, 2024

Because of how the logic works in the related links and list components the example with the social links and icons(https://service-manual.ons.gov.uk/design-system/components/related-content/example-related-content-social-media) has the ons-list--bare class added twice.

The logic needs updating so it is only added once but this will have implications on other lists that don't use the social icons because this logic is also used by them so there may be some refactoring needed, this will have to be taken into considerations when fixing this bug.

download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Low Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants