Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated front matter and links of two examples #3183

Conversation

alessioventuriniAND
Copy link
Contributor

@alessioventuriniAND alessioventuriniAND commented May 9, 2024

What is the context of this PR?

This fixes: #3182

I have removed the layout: example from the front matter of one example as it didn't really add anything to the example layout itself.

I have also updated the layout: none to layout: ~ . This has also fixed an issue with one example that was not displaying correctly.

Lastly I have update two links within the same component as they were pointing to an old path.

How to review this PR

Pull this branch and confirm that the changed examples are working as expected.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@alessioventuriniAND alessioventuriniAND added the Bug Something isn't working label May 9, 2024
@alessioventuriniAND alessioventuriniAND self-assigned this May 9, 2024
@alessioventuriniAND alessioventuriniAND linked an issue May 9, 2024 that may be closed by this pull request
Copy link

netlify bot commented May 9, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit fa34385
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/664211a728406100080e89c9
😎 Deploy Preview https://deploy-preview-3183--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessioventuriniAND alessioventuriniAND requested a review from a team May 9, 2024 08:51
@adi-unni adi-unni self-requested a review May 9, 2024 15:22
@precious-onyenaucheya-ons precious-onyenaucheya-ons merged commit 25fc29f into main May 13, 2024
9 checks passed
@precious-onyenaucheya-ons precious-onyenaucheya-ons deleted the enhancement/3182/update-front-matters-of-examples branch May 13, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update front matters of examples and outdated links
5 participants