Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update front matters of examples and outdated links #3182

Closed
alessioventuriniAND opened this issue May 9, 2024 · 1 comment · Fixed by #3183
Closed

Update front matters of examples and outdated links #3182

alessioventuriniAND opened this issue May 9, 2024 · 1 comment · Fixed by #3183
Assignees
@alessioventuriniAND
Labels
Enhancement Change of existing feature

Comments

@alessioventuriniAND
Copy link
Contributor

alessioventuriniAND commented May 9, 2024 •
edited
Loading

We need to update/remove the below values from the front matter of some examples to align them with the rest of the examples components.

  • Remove layout: example from frontmatter of examples in DS
  • Modify examples to specify layout: ~ instead of layout: none in DS
@alessioventuriniAND alessioventuriniAND self-assigned this May 9, 2024
@alessioventuriniAND alessioventuriniAND added the Enhancement Change of existing feature label May 9, 2024
@alessioventuriniAND
Copy link
Contributor Author

alessioventuriniAND commented May 9, 2024 •
edited
Loading

Once this ticket is completed and released we can then work on : https://github.com/orgs/ONSdigital/projects/21/views/1?pane=issue&itemId=11770046

@alessioventuriniAND alessioventuriniAND changed the title Remove redundant values from front matter Update front matters of examples May 9, 2024
@alessioventuriniAND alessioventuriniAND mentioned this issue May 9, 2024
Merged
2 tasks
@alessioventuriniAND alessioventuriniAND linked a pull request May 9, 2024 that will close this issue
Updated front matter and links of two examples #3183
Merged
2 tasks
@alessioventuriniAND alessioventuriniAND changed the title Update front matters of examples Update front matters of examples and outdated links May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessioventuriniAND alessioventuriniAND

Labels
Enhancement Change of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated front matter and links of two examples ONSdigital/design-system
1 participant
@alessioventuriniAND