Update babel preset-env and other dependancies #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alessioventuriniAND
approved these changes
May 7, 2024
balibirchlee
suggested changes
May 8, 2024
balibirchlee
approved these changes
May 16, 2024
SriHV
approved these changes
May 17, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: ONSdigital/design-team#56
This updates
@babel/preset-envto remove the caniuse-lite warning. It also updates the lock file so there will be other dependencies within that that are updated unless they are pinned to a specific version but this will be limited minor updates within the rules set in thepackage.json.I have also deleted my local lock file and re run
yarnto check for any warnings when recreating that, there were a few so I have fixed as many as I could and now there are only a few that can only be fixed by new releases of dependancies which we will have to wait for.The node version has also been updated and there are some minor formatting/documentation fixes.
Some VR test images needed updating. These seem to only be minor changes. The main one seems to be the lower case "g" is now a open g on links/buttons and not a closed one. But this actually means its more consistent with the non link font as this uses an open g. This may need to be discussed with Joe and Dina to see if it is a problem. It will have come from one of the minor updates that will have been made within the lock file.
How to review this PR
yarn starton main, see that the warning is printed in the terminalyarn starton this branch, see that the warning is now goneyarnon main, see the number of warningsyarnon this branch, see there are fewer warningsChecklist
This needs to be completed by the person raising the PR.