-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node and BackstopJS #3094
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
8867450
to
1b8dcc4
Compare
8264927
to
bee39f8
Compare
3e212fd
to
e36c7d9
Compare
4f4ccad
to
92a72fe
Compare
…al/design-system into update-puppeteer-and-backstopjs
Most of these changes will be fixed in another PR. We should raise a seperate PR to look into the issues around backstop |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Fixes: ONSdigital/design-team#60
This solves the warning we are seeing in the logs when our VR tests are run.
I have updated a few dependecies including node and backstopjs.
@babel/preset-env
has also been updated which will fix the caniuse lite warning when runningyarn start
Also codecov has been removed because we no longer use it.
There are also a few docs and formatting changes
How to review this PR
yarn start
Checklist
This needs to be completed by the person raising the PR.