Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node and BackstopJS #3094

Closed
wants to merge 38 commits into from
Closed

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Mar 15, 2024

What is the context of this PR?

Fixes: ONSdigital/design-team#60

This solves the warning we are seeing in the logs when our VR tests are run.

I have updated a few dependecies including node and backstopjs.

@babel/preset-env has also been updated which will fix the caniuse lite warning when running yarn start

Screenshot 2024-04-25 at 15 45 50

Also codecov has been removed because we no longer use it.

There are also a few docs and formatting changes

How to review this PR

  • Tests pass
  • Changes make sense
  • Check that the warning in the installing dependancies step of the VR tests action is now gone
  • Check that the caniuse lite warning is now gone when running yarn start

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@rmccar rmccar added the Dependencies Pull requests that update a dependency file label Mar 15, 2024
@rmccar rmccar self-assigned this Mar 15, 2024
Copy link

netlify bot commented Mar 15, 2024

Deploy Preview for ons-design-system-preview ready!

Name Link
🔨 Latest commit 9b3ed4c
🔍 Latest deploy log https://app.netlify.com/sites/ons-design-system-preview/deploys/6633d7838355bb0008cab9cb
😎 Deploy Preview https://deploy-preview-3094--ons-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmccar rmccar force-pushed the update-puppeteer-and-backstopjs branch from 8867450 to 1b8dcc4 Compare March 15, 2024 10:20
@rmccar rmccar force-pushed the update-puppeteer-and-backstopjs branch from 8264927 to bee39f8 Compare March 15, 2024 12:22
@rmccar rmccar force-pushed the update-puppeteer-and-backstopjs branch from 3e212fd to e36c7d9 Compare March 15, 2024 14:35
@rmccar rmccar changed the title Update puppeteer and backstopjs Update node and backstopjs Mar 15, 2024
@rmccar rmccar marked this pull request as ready for review March 15, 2024 23:29
@rmccar rmccar marked this pull request as draft March 19, 2024 11:52
@rmccar rmccar force-pushed the update-puppeteer-and-backstopjs branch from 4f4ccad to 92a72fe Compare March 21, 2024 10:58
@rmccar rmccar changed the title Update node and backstopjs Update Node and BackstopJS Apr 18, 2024
@rmccar
Copy link
Contributor Author

rmccar commented May 3, 2024

Most of these changes will be fixed in another PR. We should raise a seperate PR to look into the issues around backstop

@rmccar rmccar closed this May 3, 2024
@rmccar rmccar deleted the update-puppeteer-and-backstopjs branch May 23, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning in VR tests install dependancies step
2 participants