Share page component updates to new "𝕏" icon #2883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rmccar
reviewed
Nov 3, 2023
|
Team has been consulted. Whilst twitter documentation is unclear and their marketing material is even more (the main page is still www.twitter.com but the page title is X and the logo is X), the decision has been made that the hyperlink text should be kept as twitter. |
rmccar
approved these changes
Nov 6, 2023
precious-onyenaucheya-ons
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Old component had the old twitter bird icon. New component has the new SVG for "𝕏" icon. Additional change has been made to fix alignment issues between the different icons. Now all icons are in line
How to review this PR
Go to share page, and check icons are in line, and the new twitter "𝕏" icon can be seen.
Checklist
This needs to be completed by the person raising the PR.