Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Share page component needs updating #2867

Closed
alessioventuriniAND opened this issue Oct 23, 2023 · 0 comments · Fixed by #2883
Closed

[Bug]: Share page component needs updating #2867

alessioventuriniAND opened this issue Oct 23, 2023 · 0 comments · Fixed by #2883
Assignees
Labels
Bug Something isn't working

Comments

@alessioventuriniAND
Copy link
Contributor

What happened?

This component https://service-manual.ons.gov.uk/design-system/components/share-page needs updating to replace twitter Icon and name with X. The alignment of the icons also needs to be fixed as they currently look misaligned.

What was the expected outcome?

New X Icon and name and network icons aligned.

How is this problem impacting your service?

The IDS website had to remove the share section from our news article.

What list of steps can be followed to reproduce the bug or issue?

Look at the component from within the DS repo.

Example

No response

What version of the ONS Design System are you using?

66.0.2

What devices are you seeing the problem on?

Desktop, Mobile, Tablet

Device details

No response

What operating systems are you seeing the problem on?

No response

Operating system details

No response

What browsers are you seeing the problem on?

No response

Browser details

No response

@alessioventuriniAND alessioventuriniAND added the Bug Something isn't working label Oct 23, 2023
@adi-unni adi-unni self-assigned this Nov 1, 2023
@adi-unni adi-unni linked a pull request Nov 2, 2023 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants