[16.0][ADD] stock_release_channel_process_end_time #550

rousseldenis · 2023-01-30T16:39:50Z

Depends on :

lmignon · 2023-02-01T11:18:40Z

stock_release_channel_process_end_date/models/stock_release_channel.py

+
+    _inherit = "stock.release.channel"
+
+    process_end_date = fields.Datetime(


@rousseldenis A release channel instance is not created every day. A release channel is a way to organize your pick to deliver process into your company. It's therefore useless to specify the date and time when the process of pickings should be completed. IMO, this process_end_date should be replaced by a process_end_time...
@jbaudoux What do you thing about?

@rousseldenis A release channel instance is not created every day. A release channel is a way to organize your pick to deliver process into your company. It's therefore useless to specify the date and time when the process of pickings should be completed. IMO, this process_end_date should be replaced by a process_end_time...

@lmignon Ok, didn't catch that.

The only drawback I see is that is not flexible (but maybe it's wanted - I don't have the whole flow in mind) as one may want to have channel opened during the day, but pickings done during the night (so, overlap between two days)

lmignon · 2023-02-07T09:13:50Z

test-requirements.txt

@@ -0,0 +1,2 @@
+odoo-addon-stock-release-channel @ git+https://github.com/OCA/wms.git@refs/pull/506/head#subdirectory=setup/stock_release_channel
+odoo-addon-stock-available-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_promise_release


Suggested change

odoo-addon-stock-available-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_promise_release

odoo-addon-stock-available-to-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_to_promise_release

rousseldenis · 2023-02-08T10:46:23Z

@lmignon This one is ready

lmignon · 2023-02-08T13:59:13Z

stock_release_channel_process_end_time/models/stock_release_channel.py

+    @api.model
+    def assign_release_channel(self, picking):
+        res = super().assign_release_channel(picking)
+        # Check if a channel has been assigned to the picking and write scheduled_date


@rousseldenis For my information, are you sure that a write is triggered if we assign the same value?

Yes. Checked.

We pass always in that line:

https://github.com/odoo/odoo/blob/16.0/odoo/fields.py#L1320

In fact, I think this is done at purpose to avoid maybe a unneeded read if field value is not in the cache (to be able to compare) and to be able to update the write_uid/write_date as in fact, people try to update the record even if value is the same.

stock_release_channel_process_end_time/utils.py

lmignon

A little change required but work as expected

stock_release_channel_process_end_time/utils.py

lmignon

LGTM (Code review, functional tests)

lmignon

@rousseldenis The process_end_date field is not taken into account into the computation of domains used to retrieve pickings to release | late | done
As consequence, if the process_end_date is computed to tomorrow, the pickings assigned to the channel will not be taken visible since the scheduled_date will be set at tomorrow and the date criteria into the domains is set to today... (see https://github.com/OCA/wms/pull/493/files#diff-a8bb5a8dfb388e49242b1d9fe2274b33dccde4e032d0983647f70fa52399ecbcR174)

implemented in 8f20385

lmignon · 2023-02-20T13:37:22Z

@rousseldenis Changes to the process_end_time is not applied to the process_end_date and pickings to process (maybe it's overkill???)

jbaudoux

Some typo in the helps

stock_release_channel_process_end_time/models/stock_picking.py

stock_release_channel_process_end_time/models/stock_release_channel.py

jbaudoux

What's the reason behind this new config? In which situation you don't want to plan the work for the given end date?
In my opinion, we should have by default the option active.
If the option is inactive, we should still never have a scheduled date > process end date. So it should still be min(release date + delay, process end date)

stock_release_channel_process_end_time/models/res_config_settings.py

jbaudoux · 2023-09-26T11:41:59Z

What's the reason behind this new config? In which situation you don't want to plan the work for the given end date? In my opinion, we should have by default the option active. If the option is inactive, we should still never have a scheduled date > process end date. So it should still be min(release date + delay, process end date)

So the option must remain inactive because it makes the test in stock_available_to_promise_release fail

simahawk · 2023-10-05T08:47:12Z

@rousseldenis ping (for the build)

simahawk · 2023-10-06T12:26:34Z

@rousseldenis do you have time to rebase and shorten/cleanup commits? I can do it otherwise

As time should be timezoned to correctly compute the real end date, consider the channel warehouse timezone or company one. If not defined, consider the timezone as UTC.

… seconds and microseconds

…fined before assignation to scheduled_date

…utation The compute of releasable picking must take into account the process end date of the stock release channel and not the current datetime. The way the ORM is working into Odoo prevent to makes query on model with criteria based on values from linked model (comparing column from model A to column of model B). To work arround this limitation, we use a specialized field with a search method. Field's search methods are considered as 'internal' search methods and therefore allows you to use a special 'inselect' operator. This kind operator is usefull since it allows to express a criteria as a plain SQL quey. Thanks to this approach we've an easy way to implement our needs with the Odoo's ORM.

…e_tz Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>

…rameter

simahawk

LG

stock_release_channel_process_end_time/models/stock_picking.py

rousseldenis · 2023-10-06T13:02:20Z

/ocabot merge nobump

OCA-git-bot · 2023-10-06T13:02:27Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-550-by-rousseldenis-bump-nobump, awaiting test results.

OCA-git-bot · 2023-10-06T13:10:05Z

Congratulations, your PR was merged at e6396f2. Thanks a lot for contributing to OCA. ❤️

rousseldenis added the needs review label Jan 30, 2023

rousseldenis added this to the 16.0 milestone Jan 30, 2023

rousseldenis force-pushed the 16.0-release_channel_date-dro branch 3 times, most recently from a1f6668 to e6b24b9 Compare January 31, 2023 10:57

lmignon reviewed Feb 1, 2023

View reviewed changes

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from e6b24b9 to 839f5ea Compare February 7, 2023 07:38

rousseldenis changed the title ~~[16.0][ADD] stock_release_channel_process_end_date~~ [16.0][ADD] stock_release_channel_process_end_time Feb 7, 2023

rousseldenis force-pushed the 16.0-release_channel_date-dro branch 2 times, most recently from 62efcc7 to 68d5262 Compare February 7, 2023 07:49

lmignon reviewed Feb 7, 2023

View reviewed changes

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from 68d5262 to ca9239c Compare February 8, 2023 10:26

lmignon reviewed Feb 8, 2023

View reviewed changes

stock_release_channel_process_end_time/utils.py Show resolved Hide resolved

lmignon suggested changes Feb 8, 2023

View reviewed changes

lmignon reviewed Feb 9, 2023

View reviewed changes

stock_release_channel_process_end_time/utils.py Outdated Show resolved Hide resolved

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from f17df21 to c29d5a6 Compare February 10, 2023 08:12

lmignon approved these changes Feb 10, 2023

View reviewed changes

sbejaoui mentioned this pull request Feb 15, 2023

[16.0][ADD] stock_release_channel_shipment_advice_process_end_time #572

Merged

lmignon suggested changes Feb 20, 2023

View reviewed changes

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from c29d5a6 to e7fdfdc Compare April 27, 2023 12:54

lmignon force-pushed the 16.0-release_channel_date-dro branch from 8042afb to 8f20385 Compare May 16, 2023 09:46

lmignon approved these changes May 16, 2023

View reviewed changes

jbaudoux reviewed Jul 27, 2023

View reviewed changes

stock_release_channel_process_end_time/models/stock_picking.py Outdated Show resolved Hide resolved

stock_release_channel_process_end_time/models/stock_release_channel.py Outdated Show resolved Hide resolved

sbejaoui approved these changes Jul 27, 2023

View reviewed changes

OCA-git-bot added the approved label Jul 27, 2023

sbejaoui force-pushed the 16.0-release_channel_date-dro branch 2 times, most recently from 2494ecf to 310a615 Compare July 27, 2023 16:11

anothingguy mentioned this pull request Sep 15, 2023

[16.0] [ADD] stock_release_channel_shipment_lead_time #750

Merged

jbaudoux requested changes Sep 19, 2023

View reviewed changes

stock_release_channel_process_end_time/models/res_config_settings.py Outdated Show resolved Hide resolved

stock_release_channel_process_end_time/models/res_config_settings.py Outdated Show resolved Hide resolved

jbaudoux mentioned this pull request Sep 26, 2023

[16.0][ADD] stock_release_channel_cutoff #740

Merged

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from 049175d to ac5d844 Compare September 28, 2023 07:35

jbaudoux approved these changes Oct 6, 2023

View reviewed changes

OCA-git-bot added the approved label Oct 6, 2023

rousseldenis and others added 10 commits October 6, 2023 14:39

[16.0][ADD] stock_release_channel_process_end_date

dff8e1e

[IMP] stock_release_channel_process_end_time: Add timezone for end time

85c236e

As time should be timezoned to correctly compute the real end date, consider the channel warehouse timezone or company one. If not defined, consider the timezone as UTC.

[FIX] stock_release_channel_process_end_time: Don't take into account…

1741c32

… seconds and microseconds

[IMP] stock_release_channel_process_end_time: Check if end time is de…

b76bd69

…fined before assignation to scheduled_date

[FIX] - assign channel end date to picking after release

63d33c2

[IMP] - improve process end time location in form view

3f04f19

[FIX] fix help message & add UTC as defauly value for process_end_tim…

768f617

…e_tz Co-authored-by: Jacques-Etienne Baudoux <je@bcim.be>

[IMP] add configuration to enable/disable set scheduled date

154dbdc

[IMP] stock_release_channel_process_end_time: Rename configuration pa…

11372d0

…rameter

rousseldenis force-pushed the 16.0-release_channel_date-dro branch from ac5d844 to 11372d0 Compare October 6, 2023 12:39

simahawk approved these changes Oct 6, 2023

View reviewed changes

stock_release_channel_process_end_time/models/stock_picking.py Show resolved Hide resolved

OCA-git-bot added the bot is merging ⏳ label Oct 6, 2023

OCA-git-bot merged commit f42ec6d into OCA:16.0 Oct 6, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 6, 2023

This was referenced Oct 6, 2023

[16.0][ADD] stock_release_channel_partner_public_holidays #751

Merged

[16.0][ADD] stock_release_channel_partner_delivery_window #753

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][ADD] stock_release_channel_process_end_time #550

[16.0][ADD] stock_release_channel_process_end_time #550

rousseldenis commented Jan 30, 2023 •

edited

Loading

lmignon Feb 1, 2023

rousseldenis Feb 3, 2023

lmignon Feb 7, 2023

rousseldenis commented Feb 8, 2023

lmignon Feb 8, 2023

rousseldenis Apr 24, 2023 •

edited

Loading

lmignon left a comment

lmignon left a comment

lmignon left a comment •

edited

Loading

lmignon commented Feb 20, 2023

jbaudoux left a comment

jbaudoux left a comment

jbaudoux commented Sep 26, 2023

simahawk commented Oct 5, 2023 •

edited

Loading

simahawk commented Oct 6, 2023

simahawk left a comment

rousseldenis commented Oct 6, 2023

OCA-git-bot commented Oct 6, 2023

OCA-git-bot commented Oct 6, 2023


		_inherit = "stock.release.channel"

		process_end_date = fields.Datetime(

		@@ -0,0 +1,2 @@
		odoo-addon-stock-release-channel @ git+https://github.com/OCA/wms.git@refs/pull/506/head#subdirectory=setup/stock_release_channel
		odoo-addon-stock-available-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_promise_release

	odoo-addon-stock-available-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_promise_release
	odoo-addon-stock-available-to-promise-release @ git+https://github.com/OCA/wms.git@refs/pull/478/head#subdirectory=setup/stock_available_to_promise_release

[16.0][ADD] stock_release_channel_process_end_time #550

[16.0][ADD] stock_release_channel_process_end_time #550

Conversation

rousseldenis commented Jan 30, 2023 • edited Loading

lmignon Feb 1, 2023

Choose a reason for hiding this comment

rousseldenis Feb 3, 2023

Choose a reason for hiding this comment

lmignon Feb 7, 2023

Choose a reason for hiding this comment

rousseldenis commented Feb 8, 2023

lmignon Feb 8, 2023

Choose a reason for hiding this comment

rousseldenis Apr 24, 2023 • edited Loading

Choose a reason for hiding this comment

lmignon left a comment

Choose a reason for hiding this comment

lmignon left a comment

Choose a reason for hiding this comment

lmignon left a comment • edited Loading

Choose a reason for hiding this comment

lmignon commented Feb 20, 2023

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux left a comment

Choose a reason for hiding this comment

jbaudoux commented Sep 26, 2023

simahawk commented Oct 5, 2023 • edited Loading

simahawk commented Oct 6, 2023

simahawk left a comment

Choose a reason for hiding this comment

rousseldenis commented Oct 6, 2023

OCA-git-bot commented Oct 6, 2023

OCA-git-bot commented Oct 6, 2023

rousseldenis commented Jan 30, 2023 •

edited

Loading

rousseldenis Apr 24, 2023 •

edited

Loading

lmignon left a comment •

edited

Loading

simahawk commented Oct 5, 2023 •

edited

Loading