Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_release_channel: Migration to 16.0 #493

Merged
merged 7 commits into from
Mar 10, 2023
Merged

[16.0][MIG] stock_release_channel: Migration to 16.0 #493

merged 7 commits into from
Mar 10, 2023

Conversation

lmignon
Copy link
Contributor

@lmignon lmignon commented Nov 14, 2022

No description provided.

@rousseldenis
Copy link
Contributor

/ocabot migration stock_release_channel

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Nov 15, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 15, 2022
Open
18 tasks
@lmignon lmignon mentioned this pull request Nov 24, 2022
Merged
2 tasks
@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch from 4b05fb5 to 4f25a4f Compare January 10, 2023 17:57
@lmignon lmignon mentioned this pull request Jan 11, 2023
Merged
1 task
@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch from 4f25a4f to 415cd2c Compare January 11, 2023 10:35
rousseldenis
rousseldenis reviewed Jan 30, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

stock_release_channel/models/stock_release_channel.py Outdated
for channel in self:
domain = self._field_picking_domains()["count_picking_released"]
domain += [("release_channel_id", "=", channel.id)]
released = self.env["stock.picking"].search(domain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid several search DB queries, I would have put this outside the loop and then filter on the release channel

stock_release_channel/models/stock_release_channel.py Outdated Show resolved Hide resolved
stock_release_channel/models/stock_release_channel.py Outdated Show resolved Hide resolved
stock_release_channel/models/stock_release_channel.py Outdated Show resolved Hide resolved
stock_release_channel/models/stock_release_channel.py Outdated Show resolved Hide resolved
stock_release_channel/models/stock_release_channel.py Outdated Show resolved Hide resolved
@rousseldenis rousseldenis mentioned this pull request Jan 30, 2023
Merged
@sbejaoui sbejaoui mentioned this pull request Feb 7, 2023
Closed
@sbejaoui sbejaoui force-pushed the 16.0-mig-stock_release_channel branch from 415cd2c to f48f458 Compare March 7, 2023 14:39
sbejaoui
sbejaoui approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@sbejaoui sbejaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test

@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch from 769244b to bc83a5d Compare March 9, 2023 13:45
@simahawk
Copy link
Contributor

Same as #470

@simahawk
Copy link
Contributor

#600

@simahawk
Copy link
Contributor

@lmignon can you rebase pls?

@simahawk simahawk mentioned this pull request Mar 10, 2023
Merged
@simahawk
Copy link
Contributor

@lmignon after reading your comment on #470 I can rollback #600 if you want.

@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch from bc83a5d to 070037e Compare March 10, 2023 14:35
lmignon and others added 6 commits March 10, 2023 15:37
@lmignon
[MIG] stock_release_channel: Migration to 16.0
9abda15
@jbaudoux @lmignon
stock_release_channel: multi warehouse
414ca9c 
Organize release channels by warehouse.
Ease the configuration of release channel by picking types.
@jbaudoux @lmignon
stock_release_channel: assign channel
21f1ae0 
When the move is not generated by a SO, also assign the release channel
@sbejaoui @lmignon
[IMP] - improve release channel form view by adding notebook
1a0bfee
@sbejaoui @lmignon
[IMP] - stock_release_channel: better inheritance of assign_release_c…
40af692 
…hannel
@lmignon
[FIX] stock_release_channel: Remove dependency on sale
160707d 
The dependency on sale addon is no more required thanks to changes in OCA@e334ddc
@lmignon lmignon force-pushed the 16.0-mig-stock_release_channel branch from 070037e to 160707d Compare March 10, 2023 14:37
@lmignon
Copy link
Contributor Author

lmignon commented Mar 10, 2023

@simahawk rebase done....

simahawk
simahawk approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-493-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fe311fd into OCA:16.0 Mar 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 28daa54. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

@simahawk simahawk simahawk approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@sbejaoui sbejaoui sbejaoui approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lmignon @rousseldenis @simahawk @OCA-git-bot @jbaudoux @sbejaoui