Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

Fix example to be able to match tags #11

Merged
merged 1 commit into from
Aug 29, 2017
Merged

Conversation

henrikra
Copy link

@henrikra henrikra commented Jul 27, 2017

The example XML file in README was wrong. Looking at NFC basics it says:

Your activity is considered a match if a tech-list set is a subset of the technologies that are supported by the tag

This means that if my tag supports IsoDep and NfcA I do not get event from this library because the current tech-list is NOT subset of IsoDep and NfcA. But when when all techs are in own tech-list they are always subset of tag's supported techs. So basically doing XML file like this it is good default when trying out the library. Later on if the coder wants he can filter out techs that he does not want :)

@smitch88 also explained this problem in #7

This will fix issues #1 #2 #4 #7

Please ask if you have more questions :)

@henrikra henrikra changed the title Fix example to be able to match all kinds of tags Fix example to be able to match tags Jul 27, 2017
@giordy giordy merged commit bec44b3 into Novadart:develop Aug 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants