Skip to content
This repository was archived by the owner on Nov 26, 2020. It is now read-only.

tech-list README reference issue - subtle pain point #7

Open
smitch88 opened this issue Jul 5, 2017 · 3 comments
Open

tech-list README reference issue - subtle pain point #7

smitch88 opened this issue Jul 5, 2017 · 3 comments

Comments

@smitch88
Copy link

smitch88 commented Jul 5, 2017

I think the way you are defining the tech-list in the README.md is incorrect for capturing a multitude of tag types. In its current form it acts as a logical AND but I think you really want this list to act like an OR. I was getting errors in the README.md format (e.g, showing the default nfc reader tag read) but switched to something like...

<?xml version="1.0" encoding="utf-8"?>
<resources xmlns:xliff="urn:oasis:names:tc:xliff:document:1.2">
  <tech-list>
    <tech>android.nfc.tech.Ndef</tech>
  </tech-list>
  <tech-list>
    <tech>android.nfc.tech.MifareUltralight</tech>
  </tech-list>
  <tech-list>
    <tech>android.nfc.tech.MifareClassic</tech>
  </tech-list>
</resources>

And now it actually seems to read correctly across various tag types that I am using.

Great work btw on the library!

@smitch88 smitch88 changed the title tech-list issues tech-list readme issues Jul 5, 2017
@smitch88 smitch88 changed the title tech-list readme issues tech-list README reference issues - subtle pain point Jul 5, 2017
@smitch88 smitch88 changed the title tech-list README reference issues - subtle pain point tech-list README reference issue - subtle pain point Jul 5, 2017
@giordy
Copy link
Member

giordy commented Jul 6, 2017

Thanks for reporting this!
I must admit it is rather weird, "tech-list" suggests in fact to add a list of techs you would support.
Besides, how would it work as a "AND" o.O a card usually contains 1 chip tech AFAIK (but I could be wrong)

@smitch88
Copy link
Author

smitch88 commented Jul 6, 2017

I was using an app NFC tools to read tags and most tags do have multiple types they support and list themselves as what they support. For example, the ones I was reading supported ndef, nfcf, and one other one that I can't remember off the top of my head. Anyway, you could AND those to be more restrictive so it suits a very specific read use case but I found it quite annoying to work with it like that.

@giordy
Copy link
Member

giordy commented Jul 6, 2017

ok, interesting ^^
I will udpate the README

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants