Create and install a version file for the hiredis-cluster CMake package #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables users to ask for a specific version like: find_package(hiredis_cluster 0.10.1 REQUIRED) which will accept all 0.10.x versions but not 0.11.0
Since CMake find_package() can't find required information from a fetched dependency without jumping through hoops a version stub file is also created. This is needed when hiredis-cluster is downloading hiredis to make CMake understand which hiredis version it is using.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version file for the CMake package enables users to ask for a specific version like:
find_package(hiredis_cluster 0.10.1 REQUIRED)which will find and accept all
0.10.xversions but not0.11.0(using CMakePackageConfigHelpers).Additionally, this PR fixes a problem that CMake's
find_package()don't understand which version that is used when the build downloads the hiredis package usingFetchContent. This is fixed by creating a version file stub containing the package version.This fixes a problem seen in PR #150, a testcase that should be run when using hiredis 1.0.1 will not run even when the build downloads hiredis 1.0.1.