Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of redirects with hostname #150

Merged
merged 5 commits into from
Apr 26, 2023

Conversation

bjosv
Copy link
Collaborator

@bjosv bjosv commented Mar 10, 2023

The async testcase is run depending on used hiredis version due to redis/hiredis#1171.

CI is updated to a pre-v1.1.1 version of hiredis to make sure we run the added testcase,
but local builds will keep its old behavior.

bjosv added 4 commits March 10, 2023 13:27
The testcase redirect-with-hostname-test-async will not work due to
a bug in hiredis, so it's disabled if the hiredis version is 1.1.0 or
if the version is unknown.
@bjosv bjosv marked this pull request as ready for review April 24, 2023 16:37
@bjosv bjosv requested a review from zuiderkwast April 24, 2023 16:38
Copy link
Collaborator

@zuiderkwast zuiderkwast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this one, which led us to find the embarrassing hiredis bug.

Looks good. Just some question.

tests/CMakeLists.txt Show resolved Hide resolved
@bjosv bjosv merged commit 8f65285 into Nordix:master Apr 26, 2023
@bjosv bjosv deleted the redirect-with-hostname branch April 26, 2023 14:00
@bjosv bjosv linked an issue Apr 27, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to verify correct handling of hostname in redirects
2 participants