-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uhd: 3.14.0.0 -> 3.15.0.0 #84183
uhd: 3.14.0.0 -> 3.15.0.0 #84183
Conversation
Use rec instead of let in and use only 1 version attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't see why we need uhd to be so configurable (i.e. all the device flags), but it's not important.
Some of the options make the ensuing binary much smaller. Like removing
some of the X300 images. This can matter when trying to deploy to small
distributed systems.
…On Fri, Apr 3, 2020 at 8:27 AM Bjørn Forsman ***@***.***> wrote:
***@***.**** approved this pull request.
Nit: I don't see why we need uhd to be so configurable (i.e. all the
device flags), but it's not important.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#84183 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLSDF3H7X5WUYJV7ZFMLTRKXI4BANCNFSM4L34UFRQ>
.
|
Thanks for your approval @bjornfor ,
|
The build results nixpkgs-review produced are available via cachix - https://app.cachix.org/cache/r-doronbehar . These are the store paths :
|
@GrahamcOfBorg eval |
Motivation for this change
Update + Make uhd's build more configurable.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)