Some PRs trigger: code: 2, kind: NotFound, message: "No such file or directory"

[doronbehar]

I see this error on several PRs with seemingly OK syntax:

Failed during the setup of executing nix-env: Os { code: 2, kind: NotFound, message: "No such file or directory" }

Examples:

• guix: init at 1.1.0 nixpkgs#84004
• mirage: init at 0.5.1 nixpkgs#84150
• quaternion: update, libquotient: init nixpkgs#84160

If the PRs themselves have something wrong with them, I think at least the error message could be better?

[doronbehar]

There's also this error coming out for me.

[cole-h]

This is because ofborg currently propagates IO errors with little-to-no context. The problematic function could be one of these two:

ofborg/ofborg/src/nixenv.rs

Line 62 in a872255

fn place_nix(&self) -> Result<(), std::io::Error> {

ofborg/ofborg/src/nixenv.rs

Line 69 in a872255

fn remove_nix(&self) -> Result<(), std::io::Error> {

because any std::io::Error gets transformed to the local Error enum via this line:

ofborg/ofborg/src/nixenv.rs

Line 124 in a872255

Error::Io(e) => format!("Failed during the setup of executing nix-env: {:?}", e),

losing all context. I'm working on a PR for this that should give more context, like what operation actually failed (was it creating the file? Removing it? Writing to it?), but I don't know what other information would be helpful, or even if that other information could be displayed.

---

The internal error tag is when something goes really wrong inside ofborg. Currently, Graham manually removes these (in order to allow himself to investigate the cause, first). Assuming it evals + builds, I would say don't worry about it (unless someone else says otherwise).

[cole-h]

The root cause appears to be: if the nix invocation fails (like when evaluating), the stats file won't be created (example log: https://gist.github.com/GrahamcOfBorg/9dfb034692a8b8397c6bdc476c6910ec). My follow-up PR at #449 demotes this to a logged warning, and should let it get to the point where ofborg reports an actual evaluation error.

EDIT: If this resurfaces, feel free to re-open or open a new issue and ping me. I'll look into it.