masterpdfeditor: 5.1.12 -> 5.1.60

[apeyroux]

Motivation for this change

masterpdfeditor: 5.1.12 -> 5.1.36

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[xeji]

What problem does this wrapper solve? The package builds and runs fine without it on my machine.

[apeyroux]

I encountered the same problem as: #24256 and I was able to fix it with this wrapper. What's weird is that we don't have the same error. I didn't need this wrapper with 5.1.12, only with 5.1.36.

[xeji]

That's a known error when you try to run Qt apps on a machine which has another Qt version installed. I'm not sure if we should add a wrapper to fix this because this may cause other problems. What does our Qt specialist @ttuegel recommend?

[ttuegel]

Wrapping the program like this will surely break it for someone. Failing to wrap the program will also surely break it for someone. There is practically no way to support Qt applications in Nixpkgs in every configuration; something is going to be broken. The only important thing is that it works for you, the maintainer. If you're going to wrap, the QT_PLUGIN_PATH entry should be ${lib.getBin qtbase}/${qtbase.qtPluginPrefix} instead of what is above.

[apeyroux]

ping @CMCDragonkai @flokli

[CMCDragonkai]

I thought we no longer needed makeWrapper due to some trick.

[flokli]

@CMCDragonkai The "trick" must be this one: #24256 (comment), which unfortunately isn't enough - see #44047.

I poked through other changes referring to that issue, and am fine with adding the wrapper, with a comment above like in https://github.com/NixOS/nixpkgs/pull/43390/files#diff-c2877cd32bac930d3156eb07aa8821fdR62
(Although we should use ${lib.getBin qtbase}/${qtbase.qtPluginPrefix} as mentioned by @ttuegel (and probably fix that in other places where the wrapping is done in a separate PR too))

@apeyroux can you update your PR with the comment and proper wrapping path?

[flokli]

@apeyroux can you prefix "masterpdfeditor: " on the first commit msg of this PR? Apart from that, ready to be merged :-)

[flokli]

Thanks!

[ajs124]

Could someone please backport this to the release channel(s), the 5.1.12 source 404s.

[flokli]

backported to release-18.09 in c5dee01, 79c8e36 and 0267a5a.

Merry Christmas!

[ajs124]

Thanks! Sadly, it seems like now they released 5.2.20 and 5.1.60 is 404ing.

Does anyone have any contact with upstream? Their behavior is really annoying.

[apeyroux]

up to 5.2.20 -> #52871