Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-cash: 3.1.6 -> 3.3.1 #43390

Merged
merged 4 commits into from
Sep 23, 2018
Merged

electron-cash: 3.1.6 -> 3.3.1 #43390

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5af608
electron-cash: 3.1.6 -> 3.3
nyanloutre Jul 3, 2018
e33a7df
electron-cash: 3.3 -> 3.3.1
nyanloutre Sep 12, 2018
f5a5752
electron-cash: fix #24256
nyanloutre Sep 12, 2018
1004dae
electron-cash: Reminder to remove the QT wrapper
nyanloutre Sep 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions pkgs/applications/misc/electron-cash/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, python3Packages }:
{ stdenv, fetchurl, python3Packages, qtbase, makeWrapper, lib }:

let

Expand All @@ -7,14 +7,14 @@ let
in

python3Packages.buildPythonApplication rec {
version = "3.1.6";
version = "3.3.1";
name = "electron-cash-${version}";

src = fetchurl {
url = "https://electroncash.org/downloads/${version}/win-linux/ElectronCash-${version}.tar.gz";
# Verified using official SHA-1 and signature from
# https://github.com/fyookball/keys-n-hashes
sha256 = "062k5iw0jcp10zxrffvgiyfg51c5xzs7gmm638icx01yy67d58dm";
sha256 = "1jdy89rfdwc2jadx3rqj5yvynpcn90cx6482ax9f1cj9gfxp9j2b";
};

propagatedBuildInputs = with python3Packages; [
Expand All @@ -36,13 +36,14 @@ python3Packages.buildPythonApplication rec {
trezor
];

nativeBuildInputs = [ makeWrapper ];

postPatch = ''
# Remove pyqt5 check
sed -i '/pyqt5/d' setup.py
'';

preBuild = ''
sed -i 's,usr_share = .*,usr_share = "'$out'/share",g' setup.py
pyrcc5 icons.qrc -o gui/qt/icons_rc.py
# Recording the creation timestamps introduces indeterminism to the build
sed -i '/Created: .*/d' gui/qt/icons_rc.py
Expand All @@ -51,18 +52,21 @@ python3Packages.buildPythonApplication rec {
doCheck = false;

postInstall = ''
# Despite setting usr_share above, these files are installed under
# $out/nix ...
mv $out/${python.sitePackages}/nix/store"/"*/share $out
rm -rf $out/${python.sitePackages}/nix
# These files are installed under $out/homeless-shelter ...
mv $out/${python.sitePackages}/homeless-shelter/.local/share $out
rm -rf $out/${python.sitePackages}/homeless-shelter

substituteInPlace $out/share/applications/electron-cash.desktop \
--replace "Exec=electron-cash %u" "Exec=$out/bin/electron-cash %u"

# Please remove this when #44047 is fixed
wrapProgram $out/bin/electron-cash \
--prefix QT_PLUGIN_PATH : ${qtbase}/lib/qt-5.${lib.versions.minor qtbase.version}/plugins
'';

doInstallCheck = true;
installCheckPhase = ''
$out/bin/electrum help >/dev/null
$out/bin/electron-cash help >/dev/null
'';

meta = with stdenv.lib; {
Expand Down