Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feishin: 1.12.1 -> 1.12.2 #377468

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

DoctorDalek1963
Copy link
Contributor

Update feishin to 1.12.2. This fixes #376166 and closes #375870 by making it redundant since this PR also updates to the fixed upstream version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@simon-bueler
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 377468


x86_64-linux

✅ 1 package built:
  • feishin

@emilylange emilylange added the backport release-24.11 Backport PR automatically label Jan 30, 2025
@emilylange emilylange merged commit 66ce283 into NixOS:master Jan 30, 2025
26 of 28 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 30, 2025

Backport failed for release-24.11, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.11
git worktree add -d .worktree/backport-377468-to-release-24.11 origin/release-24.11
cd .worktree/backport-377468-to-release-24.11
git switch --create backport-377468-to-release-24.11
git cherry-pick -x ca840a01ced92c13606cb28a68bdc2f367452f9f

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 30, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: feishin
3 participants