Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates electron version of feishin to 33 from EOL version 31 #375870

Closed
wants to merge 1 commit into from
Closed

updates electron version of feishin to 33 from EOL version 31 #375870

wants to merge 1 commit into from

Conversation

simon-bueler
Copy link

@simon-bueler simon-bueler commented Jan 22, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

fixes #376166

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 22, 2025
@nix-owners nix-owners bot requested review from jlbribeiro and onny January 22, 2025 16:51
@ghost ghost mentioned this pull request Jan 23, 2025
Closed
3 tasks
@simon-bueler simon-bueler mentioned this pull request Jan 24, 2025
Closed
@simon-bueler
Copy link
Author

@onny & @jlbribeiro is there anything blocking this from review or merge? Sorry first time contribution and I don't know the whole process.

@qoh
Copy link

qoh commented Jan 27, 2025

Upstream version 0.12.2 upgraded Electron to 33:
https://github.com/jeffvli/feishin/releases/tag/v0.12.2

@DoctorDalek1963 DoctorDalek1963 mentioned this pull request Jan 28, 2025
Merged
13 tasks
@simon-bueler
Copy link
Author

Closing in favor of #377468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlbribeiro jlbribeiro Awaiting requested review from jlbribeiro

@onny onny Awaiting requested review from onny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure: feishin
3 participants
@simon-bueler @qoh @NixOSInfra