Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] gdcm: switch to new sdk pattern on darwin and fixes build #359669

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to release-24.11, triggered by a label in #358792.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 28, 2024
@ofborg ofborg bot requested a review from tfmoraes November 28, 2024 14:47
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 28, 2024
@wolfgangwalther
Copy link
Contributor

Result of nixpkgs-review pr 359669 run on aarch64-darwin 1

27 packages marked as broken and skipped:
  • c3d
  • intensity-normalization
  • intensity-normalization.dist
  • python311Packages.intensity-normalization
  • python311Packages.intensity-normalization.dist
  • python311Packages.medpy
  • python311Packages.medpy.dist
  • python311Packages.pydicom-seg
  • python311Packages.pydicom-seg.dist
  • python311Packages.pymedio
  • python311Packages.pymedio.dist
  • python311Packages.pyradiomics
  • python311Packages.pyradiomics.dist
  • python311Packages.torchio
  • python311Packages.torchio.dist
  • python312Packages.intensity-normalization
  • python312Packages.intensity-normalization.dist
  • python312Packages.medpy
  • python312Packages.medpy.dist
  • python312Packages.pydicom-seg
  • python312Packages.pydicom-seg.dist
  • python312Packages.pymedio
  • python312Packages.pymedio.dist
  • python312Packages.pyradiomics
  • python312Packages.pyradiomics.dist
  • python312Packages.torchio
  • python312Packages.torchio.dist
11 packages failed to build:
  • ants
  • gdcm
  • itk (itk_5)
  • itk_5_2
  • octavePackages.dicom
  • python311Packages.dicom2nifti
  • python311Packages.dicom2nifti.dist
  • python311Packages.gdcm
  • python312Packages.dicom2nifti
  • python312Packages.dicom2nifti.dist
  • python312Packages.gdcm

@wolfgangwalther
Copy link
Contributor

This fails with this:

-- Could NOT find LibXslt (missing: LIBXSLT_LIBRARIES LIBXSLT_INCLUDE_DIR)
CMake Warning at Utilities/doxygen/CMakeLists.txt:332 (message):
  Cannot build man page from docbook (need an XSL processor)


-- Configuring done (9.1s)
CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



CMake Error in Utilities/VTK/Applications/CMakeLists.txt:
  Imported target "VTK::RenderingOpenGL2" includes non-existent path

    "/nix/store/kv941gdcjskclv2phb141s36ah88i6sx-OpenGL-11.0/Library/Frameworks"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.



-- Generating done (0.3s)
CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    CMAKE_INSTALL_DOCDIR
    CMAKE_INSTALL_INCLUDEDIR
    CMAKE_INSTALL_INFODIR
    CMAKE_INSTALL_LIBEXECDIR
    CMAKE_INSTALL_LOCALEDIR
    CMAKE_INSTALL_MANDIR
    CMAKE_INSTALL_OLDINCLUDEDIR
    CMAKE_INSTALL_SBINDIR
    CMAKE_POLICY_DEFAULT_CMP0025


CMake Generate step failed.  Build files cannot be regenerated correctly.

@wolfgangwalther wolfgangwalther marked this pull request as draft December 1, 2024 18:45
@wegank
Copy link
Member

wegank commented Dec 6, 2024

Depends on #359457

@wegank wegank marked this pull request as ready for review December 6, 2024 16:14
@wegank wegank merged commit 00a92c2 into release-24.11 Dec 6, 2024
22 of 23 checks passed
@wegank wegank deleted the backport-358792-to-release-24.11 branch December 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants