Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gdcm: switch to new sdk pattern on darwin and fixes build #358792

Merged
merged 1 commit into from
Nov 27, 2024
Merged

gdcm: switch to new sdk pattern on darwin and fixes build #358792

merged 1 commit into from
Nov 27, 2024

Conversation

tricktron
Copy link
Member

@tricktron tricktron commented Nov 24, 2024 •
edited
Loading

Things done

Switch to the new sdk pattern on darwin and together with #358790 the build on darwin is fixed.

Needs 24.11 backport for ZHF #ZurichZHF

ZHF: #352882

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tricktron tricktron added 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign backport release-24.11 Backport PR automatically labels Nov 24, 2024
@tricktron tricktron force-pushed the switch-gdcm-to-new-sdk-pattern branch 2 times, most recently from 3701ba7 to 7377f10 Compare November 25, 2024 06:36
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 25, 2024
@ofborg ofborg bot requested a review from tfmoraes November 25, 2024 22:03
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 25, 2024
@tricktron tricktron force-pushed the switch-gdcm-to-new-sdk-pattern branch from 7377f10 to 6b4a158 Compare November 26, 2024 07:36
@tricktron tricktron force-pushed the switch-gdcm-to-new-sdk-pattern branch from 6b4a158 to 1fb09cb Compare November 26, 2024 07:38
@wegank wegank merged commit 4a60dea into NixOS:master Nov 27, 2024
33 of 34 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-24.11:

@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilazy emilazy emilazy left review comments

@tfmoraes tfmoraes Awaiting requested review from tfmoraes

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tricktron @emilazy @wegank