Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wechat-uos: 4.0.0.21 -> 4.0.0.23 #354378

Merged

Conversation

pokon548
Copy link
Contributor

@pokon548 pokon548 commented Nov 8, 2024

  • Update wechat-uos to 4.0.0.23.
  • Remove libuosdevicea and license as they no longer needed in >4.0.0.21.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pokon548 pokon548 marked this pull request as ready for review November 8, 2024 02:48
@pokon548 pokon548 changed the title wechat-uos: Remove libuosdevicea and license as they no longer needed in 4.0.0.21 wechat-uos: 4.0.0.21 -> 4.0.0.23 Nov 8, 2024
@ofborg ofborg bot requested a review from xddxdd November 8, 2024 05:39
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2024
@wineee
Copy link
Member

wineee commented Nov 8, 2024

Tested on x86-linux

@wineee wineee merged commit d5a0dbe into NixOS:master Nov 8, 2024
41 of 42 checks passed
Copy link
Contributor

Backport failed for release-24.05, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release-24.05
git worktree add -d .worktree/backport-354378-to-release-24.05 origin/release-24.05
cd .worktree/backport-354378-to-release-24.05
git switch --create backport-354378-to-release-24.05
git cherry-pick -x fd10acfd9427c5d497afc732a1f61e6935650095 21107d7bc10cc13e5a0af618fe30ff4a9ca32d97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants