Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package request: WeChat #354234

Open
Seeker0472 opened this issue Nov 7, 2024 · 8 comments · May be fixed by #354332 or #354355
Open

Package request: WeChat #354234

Seeker0472 opened this issue Nov 7, 2024 · 8 comments · May be fixed by #354332 or #354355
Labels
0.kind: packaging request Request for a new package to be added

Comments

@Seeker0472
Copy link

Seeker0472 commented Nov 7, 2024

Project description
WeChat (or Weixin/微信 in Chinese) is a Chinese instant messaging, social media, and mobile payment app developed by Tencent and is widely used in China.
And Tencent has released the official linux test version of Wechat recently(Which is different from the wechat-uos from nixpkgs).

Metadata

@Seeker0472 Seeker0472 added the 0.kind: packaging request Request for a new package to be added label Nov 7, 2024
@Seeker0472
Copy link
Author

It should be the same package, please check the master branch

@aucub However, I don't believe that's the case. The wechat-uos package in the master branch of nixpkgs was downloaded from https://uniontech.com/ and was originally designed exclusively for UOS, requiring a UOS license to operate.

@jian-lin
Copy link
Contributor

jian-lin commented Nov 7, 2024

cc wechat-uos maintainers @pokon548 @xddxdd

@pluiedev
Copy link
Member

pluiedev commented Nov 7, 2024

Looks like download links are not versioned in any way — doesn't sound stable enough for inclusion in Nixpkgs

@UlyssesZh
Copy link
Member

  inherit (stdenv.hostPlatform) system;

  src = fetchurl {
    url = {
      x86_64-linux = "https://web.archive.org/web/20241107191621/https://dldir1v6.qq.com/weixin/Universal/Linux/WeChatLinux_x86_64.AppImage";
      aarch64-linux = "https://web.archive.org/web/20241107192345/https://dldir1v6.qq.com/weixin/Universal/Linux/WeChatLinux_arm64.AppImage";
      x86_64-darwin = "https://web.archive.org/web/20241107193311/https://dldir1v6.qq.com/weixin/Universal/Mac/WeChatMac_x86_64.dmg";
      aarch64-darwin = "http://web.archive.org/web/20241107194014/https://dldir1v6.qq.com/weixin/Universal/Mac/WeChatMac_arm64.dmg";
    }.${system};
    # ...
  }

@pluiedev

@pluiedev
Copy link
Member

pluiedev commented Nov 7, 2024

Ah yes, the classic trick known as "just use the Wayback Machine"... Fair enough, I might take a look at it

@UlyssesZh
Copy link
Member

Yeah I think this has been the standard way of handling this in nixpkgs. Those links are created by me today, should be new enough.

@pluiedev pluiedev linked a pull request Nov 7, 2024 that will close this issue
13 tasks
@UlyssesZh UlyssesZh linked a pull request Nov 7, 2024 that will close this issue
13 tasks
@pokon548
Copy link
Contributor

pokon548 commented Nov 8, 2024

@aucub* However, I don't believe that's the case. The wechat-uos package in the master branch of nixpkgs was downloaded from uniontech.com* and was originally designed exclusively for UOS, requiring a UOS license to operate.

Actually, 4.0.0.21 does not require libuosdevicea and license.tar.gz anymore (Will still try to find them, but it will not break usability and will let you login even you do not had them). I just remove them in local build and wechat-uos works normally. Will upstream changes in the next PR. Edit: Done in #354378

Looks like download links are not versioned in any way — doesn't sound stable enough for inclusion in Nixpkgs

I had reached officials for this problem, but had not received any response yet.

For me, wechat-uos still has benefit in updates, as I could check updates from uniontech APT repo and easy to fetch updates automatically. Will consider rebased to official distributions after this issue is addressed.

@darkclip
Copy link

tried the official version, more functions are available, seems no bwrap anymore, overall i think it's better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: packaging request Request for a new package to be added
Projects
None yet
6 participants