nodejs: fix cross-compilation from aarch64-linux to x86_64-linux #238377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44db024 to
f637e04
Compare
|
Result of 77 packages marked as broken and skipped:
1 package blacklisted:
38 packages failed to build:
829 packages built:
|
12 tasks
There was a problem hiding this comment.
I left one comment, but otherwise this looks fine enough for me now. Do you have any other thoughts @marsam?
|
@SuperSandro2000 @lilyinstarlight, gentle ping, is there anything else blocking this PR? |
|
I am not that fit in cross to know if this is the correct way or not. |
|
I think the patch |
Building --without-snapshot is no longer possible since v14. See nodejs/node@0822bfa
This change adds a fix for Node.js build system passing flags intended for the target toolchain to the host toolchain.
tr1/type_traits replacement is only relevent for Node.js v6 that’s reached EOL in 2019.
You are right, I’ve rebased the branch and removed the patch for v20. |
marsam
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds patches for Node.js that fix cross-compilation for v18 and v20. It also enables checkPhase for a subset of test suite that does not require dependencies not bundled with the tarball.
See also #234124 (comment)
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)