pufferpanel: build frontend from source #234124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tie
commented
Jun 10, 2023
I think I’ve tracked down the cross-compilation issue to Nodejs build system. Currently I can successfully build pkgsCross.gnu64.nodejs_20 (but not 18) with the 840141d commit applied. When overriding buildNpmPackage to nodejs_20, pkgsCross.gnu64.pufferpanel successfully builds and runs on target system. |
c8d11f0 to
abe082d
Compare
12 tasks
This change updates the PufferPanel package to build frontend from source.
This change removes pathDeps argument from pufferpanel package. It is rather wasteful to rebuild package to change PATH environment variable. Instead, users should create a separate wrapper derivation or set services.pufferpanel.extraPackages in NixOS configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change updates the PufferPanel package to build frontend from source.
Note that cross-compilation withbuildNpmPackageseems to be broken (at least fromaarch64-linuxtox86_64-linux), but the frontend is platform-independent so we usepkgsBuildBuild.buildNpmPackage.It is bundled with 2.6.7 version bump since it allows us to drop upstreamed patches.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)